Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lexical-playground] Refactor: switch headings test file names #7008

Merged

Conversation

christianhg
Copy link
Contributor

Description

HeadingsEnterAtEnd.spec.mjs was called HeadingsEnterInMiddle.spec.mjs and HeadingsEnterInMiddle.spec.mjs was called HeadingsEnterAtEnd.spec.mjs. Now the file names have been switched.

The file contents have not been touched, their names have just been switched. I did consider if I should pick a new name for one of the files since this would have produced a cleaner diff. Let me know if you would prefer this instead.

Copy link

vercel bot commented Dec 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 31, 2024 9:48am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 31, 2024 9:48am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 31, 2024
`HeadingsEnterAtEnd.spec.mjs` was called `HeadingsEnterInMiddle.spec.mjs` and
`HeadingsEnterInMiddle.spec.mjs` was called `HeadingsEnterAtEnd.spec.mjs`. Now
the file names have been switched.
@christianhg christianhg force-pushed the chore-rename-headings-test-files branch from 00b8691 to 7696580 Compare December 31, 2024 09:46
Copy link

github-actions bot commented Dec 31, 2024

size-limit report 📦

Path Size
lexical - cjs 31.21 KB (0%)
lexical - esm 31.1 KB (0%)
@lexical/rich-text - cjs 40.31 KB (0%)
@lexical/rich-text - esm 33.01 KB (0%)
@lexical/plain-text - cjs 38.85 KB (0%)
@lexical/plain-text - esm 30.22 KB (0%)
@lexical/react - cjs 42.13 KB (0%)
@lexical/react - esm 34.26 KB (0%)

@etrepum etrepum added this pull request to the merge queue Jan 1, 2025
Merged via the queue into facebook:main with commit 85c08b6 Jan 1, 2025
37 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants