Skip to content

Commit

Permalink
Fix OSS build
Browse files Browse the repository at this point in the history
Summary:
The build was broken because `LithoRecyclerView` used an id defined in litho-compose module which is not open source.

Moved that id definition to rendercore module should fix the oss build.

Reviewed By: kingsleyadio

Differential Revision: D65268455

fbshipit-source-id: 731c0b00383898559fb667ea3fb080dd4ba413f9
  • Loading branch information
zielinskimz authored and facebook-github-bot committed Oct 31, 2024
1 parent ad2e773 commit 6b82ac9
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 3 deletions.
20 changes: 20 additions & 0 deletions litho-rendercore/src/main/res/values/ids.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
<?xml version="1.0" encoding="utf-8"?>
<!--
~ Copyright (c) Meta Platforms, Inc. and affiliates.
~
~ Licensed under the Apache License, Version 2.0 (the "License");
~ you may not use this file except in compliance with the License.
~ You may obtain a copy of the License at
~
~ http://www.apache.org/licenses/LICENSE-2.0
~
~ Unless required by applicable law or agreed to in writing, software
~ distributed under the License is distributed on an "AS IS" BASIS,
~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
~ See the License for the specific language governing permissions and
~ limitations under the License.
-->

<resources>
<item type="id" name="rc_pooling_container"/>
</resources>
4 changes: 2 additions & 2 deletions litho-widget/src/main/java/com/facebook/litho/widget/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ load(
"LITHO_PERF_LOGGER",
"LITHO_PROCESSOR_TARGET",
"LITHO_RENDERCORE_PRIMITIVES_TARGET",
"LITHO_RENDERCORE_PRIMITIVE_COMPONENTS_COMPOSE_RES_TARGET",
"LITHO_RENDERCORE_RES_TARGET",
"LITHO_RENDERCORE_TARGET",
"LITHO_RES_TARGET",
"LITHO_TEXTLAYOUTBUILDER_TARGET",
Expand Down Expand Up @@ -79,7 +79,7 @@ litho_android_library(
LITHO_WIDGET_RES_TARGET,
LITHO_WIDGET_ACCESSIBILITIES_TARGET,
LITHO_PERF_LOGGER,
LITHO_RENDERCORE_PRIMITIVE_COMPONENTS_COMPOSE_RES_TARGET,
LITHO_RENDERCORE_RES_TARGET,
],
exported_deps = [
LITHO_RENDERCORE_TARGET,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ public LithoRecyclerView(Context context, @Nullable AttributeSet attrs) {

public LithoRecyclerView(Context context, @Nullable AttributeSet attrs, int defStyle) {
super(context, attrs, defStyle);
setTag(com.facebook.primitive.compose.R.id.rc_pooling_container, true);
setTag(com.facebook.rendercore.R.id.rc_pooling_container, true);
}

/**
Expand Down

0 comments on commit 6b82ac9

Please sign in to comment.