Fix some tests to work with Robolectric upgrade #496
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robolectric 4 is stricter with Drawable.equals, and one of these tests was just wrong...
vinc3m1
force-pushed
the
drawabletest
branch
from
ecfa8a7
to
4cda525
Compare
vinc3m1
commented
Feb 20, 2019
| @@ -924,7 +924,7 @@ public void testGetLinkedDrawableForAnimation() { | |||
| assertThat(drawables).hasSize(1); | |||
| assertThat(drawables).contains(d3); | |||
|
|
|||
| unmount(2, mountItem2); | |||
| unmount(1, mountItem2); | |||
There was a problem hiding this comment.
this passes in robolectric3 probably due to Drawable.equals not being strict enough, so d2.equals(d3) == true in robo3 but not robo4.
There was a problem hiding this comment.
This is terrible. Thanks for fixing this.
passy
approved these changes
Feb 21, 2019
There was a problem hiding this comment.
@passy has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Thanks @vinc3m1! |
|
That's amazing. Thanks a lot for fixing this before we will actually feel that pain. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Robolectric 4 is stricter with Drawable.equals, and one of these tests was just wrong...