Compute range on sync layout #775
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinc3m1
force-pushed
the
compute_range_on_sync_layout
branch
from
56e4d33 to
66cb39a
Compare
There was a problem hiding this comment.
@adityasharat has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
The build is failing; could you please confirm and update the PR if required. |
vinc3m1
force-pushed
the
compute_range_on_sync_layout
branch
from
66cb39a to
13c9c61
Compare
|
@vinc3m1 has updated the pull request. You must reimport the pull request before landing. |
oh right thanks missed some code sorry |
vinc3m1
force-pushed
the
compute_range_on_sync_layout
branch
from
13c9c61 to
5ed1aa9
Compare
|
@vinc3m1 has updated the pull request. You must reimport the pull request before landing. |
There was a problem hiding this comment.
@adityasharat has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@adityasharat merged this pull request in 4535f06. |
vinc3m1
referenced
this pull request
Oct 15, 2021
Summary: Same as title Reviewed By: mihaelao Differential Revision: D29361136 fbshipit-source-id: d60d76ecb33b6529a5325f6234595735c1a66802
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RecyclerBinder's prefetch happens on onScroll events, but onScroll is only fired after a full frame is rendered.
For fast flings, this could lead to situations where an entire screen is rendered serially and synchronously on the main thread before any parallel layout is kicked off in onScroll.
This change kicks off parallel rendering of an estimated screen size in the direction of scroll immediately upon encountering a synchronous layout.
Combined with LayoutStateFutures, this should unblock the main thread faster than serial synchronous layout in these situations.