Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace "facebook.proguard.annotations" with "facebook.yoga.annotations" #928

Closed
wants to merge 1 commit into from
Closed

Replace "facebook.proguard.annotations" with "facebook.yoga.annotations" #928

wants to merge 1 commit into from

Commits on Jan 16, 2023

  1. Replace "facebook.proguard.annotations" with "facebook.yoga.annotations" 

    Summary:
The Yoga JNI bindings use Reflection, so we need to let ProGuard know not to strip certain annotated fields.

This is done internally using a single copy of `com.facebook.proguard.annotations` from fbandroid (sometimes), which is then repackaged externally, and published as its own whole Yoga specific package. We never actually inform the stock Gradle project of the rules for the annotations though, so apps must add these manually.

This simplifies the setup, where Yoga has its own self-contained annotations/rules. The rules are exposed for Gradle/Buck dependencies, but RN and Litho both consume Yoga via dirsync + custom Gradle logic, so we need to duplicate the proguard rules to them instead of them being propagated automatically.

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D42406641

fbshipit-source-id: 4904571a38777fd2adbaf6a848c78fd35e6919d5
    @NickGerleman @facebook-github-bot
    NickGerleman authored and facebook-github-bot committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    0cba6f4 View commit details
    Browse the repository at this point in the history