RoutingGroups: generate explicit false specializations; remove default

Summary:
Two problems with the current "default false" approach:
1) If the specialization file is not included in a translation unit, the request will incorrectly default to false. In this new approach this will be a compile error - the correct routing groups file must be included.
2) Default false means some bugs snuck in (using GetLike with something that's not a request type, e.g. a reply or void by mistake) - see stacked diffs for fixes.

Changes in this diff:
1) New special routing group "no_group" to list requests for which all *Like traits should be false. The invariant is that every request must belong to one and only one group.
2) Removes default false, and introduces explicit true/false specializations for all requests.

Reviewed By: disylh, stuclar, antonf

Differential Revision: D62321258

fbshipit-source-id: b27f1fe3c61513b31578ba48cf16ed8a2df28138

mcrouter/lib/carbon/RoutingGroups.h

@@ -40,9 +40,7 @@ constexpr auto kUpdateKey = folly::makeFixedString("update_like");
  * Request is get-like.
  */
 template <typename Request = void>
-struct GetLike {
-  static const bool value = false;
-};
+struct GetLike;
 
 template <typename Request = void>
 using GetLikeT = typename GetLike<Request>::Type;
@@ -57,9 +55,7 @@ using GetLikeT = typename GetLike<Request>::Type;
  * Request is update-like.
  */
 template <typename Request = void>
-struct UpdateLike {
-  static const bool value = false;
-};
+struct UpdateLike;
 
 template <typename Request = void>
 using UpdateLikeT = typename UpdateLike<Request>::Type;
@@ -74,9 +70,7 @@ using UpdateLikeT = typename UpdateLike<Request>::Type;
  * Request is delete-like.
  */
 template <typename Request = void>
-struct DeleteLike {
-  static const bool value = false;
-};
+struct DeleteLike;
 
 template <typename Request = void>
 using DeleteLikeT = typename DeleteLike<Request>::Type;
@@ -92,9 +86,7 @@ using DeleteLikeT = typename DeleteLike<Request>::Type;
  * Request is arithmetic-like.
  */
 template <typename Request = void>
-struct ArithmeticLike {
-  static const bool value = false;
-};
+struct ArithmeticLike;
 
 template <typename Request = void>
 using ArithmeticLikeT = typename ArithmeticLike<Request>::Type;

mcrouter/lib/carbon/example/HelloGoodbye.idl

@@ -60,6 +60,12 @@ service {
     DuplicateRoute @ "mcrouter/lib/carbon/example/DuplicateRoute.h",
     CarbonLookasideRoute @ "mcrouter/lib/carbon/example/CarbonLookasideRoute.h"
   ];
+  routing_groups: {
+    no_group: [
+        HelloRequest,
+        GoodbyeRequest,
+    ]
+  };
   gen_client_tool: true;
   compression_by_type: true;
 };

mcrouter/lib/carbon/example/gen/HelloGoodbyeRouterInfo.h

@@ -24,6 +24,7 @@
 
 #include "mcrouter/lib/carbon/example/gen/HelloGoodbyeRouteHandleIf.h"
 #include "mcrouter/lib/carbon/example/gen/HelloGoodbyeRouterStats.h"
+#include "mcrouter/lib/carbon/example/gen/HelloGoodbyeRoutingGroups.h"
 
 // Forward declarations
 namespace folly {

mcrouter/lib/carbon/example/gen/HelloGoodbyeRoutingGroups.h

@@ -0,0 +1,66 @@
+/*
+ *  Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ *  This source code is licensed under the MIT license found in the LICENSE
+ *  file in the root directory of this source tree.
+ *
+ */
+
+/*
+ *  THIS FILE IS AUTOGENERATED. DO NOT MODIFY IT; ALL CHANGES WILL BE LOST IN
+ *  VAIN.
+ *
+ *  @generated
+ */
+#pragma once
+
+#include <mcrouter/lib/carbon/RoutingGroups.h>
+
+#include "mcrouter/lib/carbon/example/gen/HelloGoodbyeMessages.h"
+
+namespace carbon {
+
+// ArithmeticLike
+template <>
+struct ArithmeticLike<hellogoodbye::GoodbyeRequest> {
+  static const bool value = false;
+};
+
+template <>
+struct ArithmeticLike<hellogoodbye::HelloRequest> {
+  static const bool value = false;
+};
+
+// DeleteLike
+template <>
+struct DeleteLike<hellogoodbye::GoodbyeRequest> {
+  static const bool value = false;
+};
+
+template <>
+struct DeleteLike<hellogoodbye::HelloRequest> {
+  static const bool value = false;
+};
+
+// GetLike
+template <>
+struct GetLike<hellogoodbye::GoodbyeRequest> {
+  static const bool value = false;
+};
+
+template <>
+struct GetLike<hellogoodbye::HelloRequest> {
+  static const bool value = false;
+};
+
+// UpdateLike
+template <>
+struct UpdateLike<hellogoodbye::GoodbyeRequest> {
+  static const bool value = false;
+};
+
+template <>
+struct UpdateLike<hellogoodbye::HelloRequest> {
+  static const bool value = false;
+};
+} // namespace carbon

mcrouter/lib/carbon/test/A.idl

@@ -29,4 +29,10 @@ reply TestAReply {
 
 service {
   enable_shutdown: true;
+
+  routing_groups: {
+    no_group: [
+        TestARequest,
+    ]
+  };
 };

mcrouter/lib/carbon/test/B.idl

@@ -28,4 +28,10 @@ reply TestBReply {
 
 service {
   enable_shutdown: true;
+
+  routing_groups: {
+    no_group: [
+        TestBRequest,
+    ]
+  };
 };

mcrouter/lib/carbon/test/CarbonTest.idl

@@ -202,4 +202,11 @@ struct StructWithOptionalEnumInt8 {
 
 service {
   enable_shutdown: true;
+
+  routing_groups: {
+    no_group: [
+        TestRequest,
+        TestRequestStringKey,
+    ]
+  };
 };

mcrouter/lib/carbon/test/CarbonThriftTest.idl

@@ -111,4 +111,12 @@ service {
   enable_shutdown: true;
   gen_client_tool: false;
   thrift_tm_thread: true;
+
+  routing_groups: {
+    no_group: [
+        ThriftTestRequest,
+        DummyThriftRequest,
+        CustomRequest,
+    ]
+  };
 };

mcrouter/lib/carbon/test/JsonClientTest.cpp

@@ -13,6 +13,7 @@
 #include "mcrouter/lib/carbon/CmdLineClient.h"
 #include "mcrouter/lib/carbon/JsonClient.h"
 #include "mcrouter/lib/carbon/test/gen/CarbonTest.h"
+#include "mcrouter/lib/carbon/test/gen/CarbonTestRoutingGroups.h"
 #include "mcrouter/lib/mc/msg.h"
 #include "mcrouter/lib/network/AsyncMcServer.h"
 #include "mcrouter/lib/network/AsyncMcServerWorker.h"

mcrouter/lib/carbon/test/gen/ARouteHandleIf.h

@@ -20,6 +20,7 @@
 #include <mcrouter/lib/RouteHandleTraverser.h>
 
 #include "mcrouter/lib/carbon/test/gen/AMessages.h"
+#include "mcrouter/lib/carbon/test/gen/BRoutingGroups.h"
 
 namespace carbon {
 namespace test {

mcrouter/lib/carbon/test/gen/ARouterInfo.h

@@ -24,6 +24,7 @@
 
 #include "mcrouter/lib/carbon/test/gen/ARouteHandleIf.h"
 #include "mcrouter/lib/carbon/test/gen/ARouterStats.h"
+#include "mcrouter/lib/carbon/test/gen/ARoutingGroups.h"
 
 // Forward declarations
 namespace folly {

mcrouter/lib/carbon/test/gen/ARoutingGroups.h

@@ -0,0 +1,46 @@
+/*
+ *  Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ *  This source code is licensed under the MIT license found in the LICENSE
+ *  file in the root directory of this source tree.
+ *
+ */
+
+/*
+ *  THIS FILE IS AUTOGENERATED. DO NOT MODIFY IT; ALL CHANGES WILL BE LOST IN
+ *  VAIN.
+ *
+ *  @generated
+ */
+#pragma once
+
+#include <mcrouter/lib/carbon/RoutingGroups.h>
+
+#include "mcrouter/lib/carbon/test/gen/AMessages.h"
+
+namespace carbon {
+
+// ArithmeticLike
+template <>
+struct ArithmeticLike<carbon::test::A::TestARequest> {
+  static const bool value = false;
+};
+
+// DeleteLike
+template <>
+struct DeleteLike<carbon::test::A::TestARequest> {
+  static const bool value = false;
+};
+
+// GetLike
+template <>
+struct GetLike<carbon::test::A::TestARequest> {
+  static const bool value = false;
+};
+
+// UpdateLike
+template <>
+struct UpdateLike<carbon::test::A::TestARequest> {
+  static const bool value = false;
+};
+} // namespace carbon

mcrouter/lib/carbon/test/gen/BRouterInfo.h

@@ -24,6 +24,7 @@
 
 #include "mcrouter/lib/carbon/test/gen/BRouteHandleIf.h"
 #include "mcrouter/lib/carbon/test/gen/BRouterStats.h"
+#include "mcrouter/lib/carbon/test/gen/BRoutingGroups.h"
 
 // Forward declarations
 namespace folly {

mcrouter/lib/carbon/test/gen/BRoutingGroups.h

@@ -0,0 +1,46 @@
+/*
+ *  Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ *  This source code is licensed under the MIT license found in the LICENSE
+ *  file in the root directory of this source tree.
+ *
+ */
+
+/*
+ *  THIS FILE IS AUTOGENERATED. DO NOT MODIFY IT; ALL CHANGES WILL BE LOST IN
+ *  VAIN.
+ *
+ *  @generated
+ */
+#pragma once
+
+#include <mcrouter/lib/carbon/RoutingGroups.h>
+
+#include "mcrouter/lib/carbon/test/gen/BMessages.h"
+
+namespace carbon {
+
+// ArithmeticLike
+template <>
+struct ArithmeticLike<carbon::test::B::TestBRequest> {
+  static const bool value = false;
+};
+
+// DeleteLike
+template <>
+struct DeleteLike<carbon::test::B::TestBRequest> {
+  static const bool value = false;
+};
+
+// GetLike
+template <>
+struct GetLike<carbon::test::B::TestBRequest> {
+  static const bool value = false;
+};
+
+// UpdateLike
+template <>
+struct UpdateLike<carbon::test::B::TestBRequest> {
+  static const bool value = false;
+};
+} // namespace carbon

mcrouter/lib/carbon/test/gen/CarbonTestRouterInfo.h

@@ -24,6 +24,7 @@
 
 #include "mcrouter/lib/carbon/test/gen/CarbonTestRouteHandleIf.h"
 #include "mcrouter/lib/carbon/test/gen/CarbonTestRouterStats.h"
+#include "mcrouter/lib/carbon/test/gen/CarbonTestRoutingGroups.h"
 
 // Forward declarations
 namespace folly {

mcrouter/lib/carbon/test/gen/CarbonTestRoutingGroups.h

@@ -0,0 +1,66 @@
+/*
+ *  Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ *  This source code is licensed under the MIT license found in the LICENSE
+ *  file in the root directory of this source tree.
+ *
+ */
+
+/*
+ *  THIS FILE IS AUTOGENERATED. DO NOT MODIFY IT; ALL CHANGES WILL BE LOST IN
+ *  VAIN.
+ *
+ *  @generated
+ */
+#pragma once
+
+#include <mcrouter/lib/carbon/RoutingGroups.h>
+
+#include "mcrouter/lib/carbon/test/gen/CarbonTestMessages.h"
+
+namespace carbon {
+
+// ArithmeticLike
+template <>
+struct ArithmeticLike<carbon::test::TestRequest> {
+  static const bool value = false;
+};
+
+template <>
+struct ArithmeticLike<carbon::test::TestRequestStringKey> {
+  static const bool value = false;
+};
+
+// DeleteLike
+template <>
+struct DeleteLike<carbon::test::TestRequest> {
+  static const bool value = false;
+};
+
+template <>
+struct DeleteLike<carbon::test::TestRequestStringKey> {
+  static const bool value = false;
+};
+
+// GetLike
+template <>
+struct GetLike<carbon::test::TestRequest> {
+  static const bool value = false;
+};
+
+template <>
+struct GetLike<carbon::test::TestRequestStringKey> {
+  static const bool value = false;
+};
+
+// UpdateLike
+template <>
+struct UpdateLike<carbon::test::TestRequest> {
+  static const bool value = false;
+};
+
+template <>
+struct UpdateLike<carbon::test::TestRequestStringKey> {
+  static const bool value = false;
+};
+} // namespace carbon

mcrouter/lib/carbon/test/gen/CarbonThriftTestRouterInfo.h

@@ -24,6 +24,7 @@
 
 #include "mcrouter/lib/carbon/test/gen/CarbonThriftTestRouteHandleIf.h"
 #include "mcrouter/lib/carbon/test/gen/CarbonThriftTestRouterStats.h"
+#include "mcrouter/lib/carbon/test/gen/CarbonThriftTestRoutingGroups.h"
 
 // Forward declarations
 namespace folly {