Skip to content

Commit

Permalink
Remove dev-mode Hermes bytecode experiment
Browse files Browse the repository at this point in the history
Summary:
Changelog:
* **[Internal]**: Remove experimental `metro-hermes-compiler` package.
* **[Fix]**: Remove spammy warning about a possible EventEmitter memory leak.

Removes the `metro-hermes-compiler` package and associated support for compiling JS to bytecode within Metro. This code was part of an unreleased experiment to offload Hermes bytecode compilation in React Native to Metro.

Reviewed By: robhogan

Differential Revision: D43604706

fbshipit-source-id: a449a51435c3eecef42ff8e7951bebb4661aee9c
  • Loading branch information
motiz88 authored and facebook-github-bot committed Mar 21, 2023
1 parent 8a43c11 commit 833f2ff
Show file tree
Hide file tree
Showing 42 changed files with 17 additions and 1,573 deletions.
5 changes: 0 additions & 5 deletions packages/metro-hermes-compiler/.npmignore

This file was deleted.

18 changes: 0 additions & 18 deletions packages/metro-hermes-compiler/README.md

This file was deleted.

18 changes: 0 additions & 18 deletions packages/metro-hermes-compiler/package.json

This file was deleted.

54 changes: 0 additions & 54 deletions packages/metro-hermes-compiler/src/__tests__/index-test.js

This file was deleted.

31 changes: 0 additions & 31 deletions packages/metro-hermes-compiler/src/emhermesc.js

This file was deleted.

59 changes: 0 additions & 59 deletions packages/metro-hermes-compiler/src/emhermesc.js.flow

This file was deleted.

196 changes: 0 additions & 196 deletions packages/metro-hermes-compiler/src/index.js

This file was deleted.

7 changes: 0 additions & 7 deletions packages/metro-runtime/src/modules/types.flow.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,20 +12,13 @@
'use strict';

export type ModuleMap = $ReadOnlyArray<[number, string]>;
export type BytecodeModuleMap = $ReadOnlyArray<[number, Array<Buffer>]>;

export type Bundle = {
+modules: ModuleMap,
+post: string,
+pre: string,
};

export type BytecodeBundle = {
+modules: BytecodeModuleMap,
+post: Array<Buffer>,
+pre: Array<Buffer>,
};

export type DeltaBundle = {
+added: ModuleMap,
+modified: ModuleMap,
Expand Down
1 change: 0 additions & 1 deletion packages/metro-transform-worker/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
"metro-babel-transformer": "0.76.0",
"metro-cache": "0.76.0",
"metro-cache-key": "0.76.0",
"metro-hermes-compiler": "0.76.0",
"metro-source-map": "0.76.0",
"metro-transform-plugins": "0.76.0",
"nullthrows": "^1.1.1"
Expand Down
Loading

0 comments on commit 833f2ff

Please sign in to comment.