Skip to content

Commit

Permalink
Increase minimum Node version from 16 to 18 (#1004)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #1004

Following the same change in React Native (facebook/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.

Changelog: [Breaking] Increase minimum Node version from 16 to 18

Reviewed By: NickGerleman

Differential Revision: D46584012

fbshipit-source-id: fde63f748667eb30e00577f6fe0dc472fa06121a
  • Loading branch information
arushikesarwani94 authored and facebook-github-bot committed Jun 22, 2023
1 parent d282a08 commit ebaf27a
Show file tree
Hide file tree
Showing 27 changed files with 31 additions and 31 deletions.
4 changes: 2 additions & 2 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ references:
# For stability, Node.js versions we run against in CI are defined explicitly
# (the "lts" alias may bring in a future version before we support it)
node_supported_lts_versions: &node_supported_lts_versions
- &node_min_supported_version "16.18"
- "18.12"
- &node_min_supported_version "18.12"
- "20.2"
node_lts_image: &node_lts_image cimg/node:18.12

secure_unset_publish_token: &secure_unset_publish_token
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"@babel/plugin-syntax-class-properties": "^7.0.0",
"@babel/plugin-transform-flow-strip-types": "^7.20.0",
"@babel/plugin-transform-modules-commonjs": "^7.0.0",
"@tsconfig/node16": "1.0.1",
"@tsconfig/node18": "1.0.1",
"@typescript-eslint/eslint-plugin": "^5.57.1",
"@typescript-eslint/parser": "^5.57.1",
"acorn": "^8.7.1",
Expand Down Expand Up @@ -89,6 +89,6 @@
"license": "MIT",
"dependencies": {},
"engines": {
"node": ">=16"
"node": ">=18"
}
}
2 changes: 1 addition & 1 deletion packages/buck-worker-tool/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@
"cleanup-release": "test ! -e build && mv src build && mv src.real src"
},
"engines": {
"node": ">=16"
"node": ">=18"
}
}
2 changes: 1 addition & 1 deletion packages/metro-babel-register/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,6 @@
},
"license": "MIT",
"engines": {
"node": ">=16"
"node": ">=18"
}
}
2 changes: 1 addition & 1 deletion packages/metro-babel-transformer/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,6 @@
"nullthrows": "^1.1.1"
},
"engines": {
"node": ">=16"
"node": ">=18"
}
}
2 changes: 1 addition & 1 deletion packages/metro-cache-key/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@
"metro-memory-fs": "0.76.7"
},
"engines": {
"node": ">=16"
"node": ">=18"
}
}
2 changes: 1 addition & 1 deletion packages/metro-cache/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,6 @@
},
"license": "MIT",
"engines": {
"node": ">=16"
"node": ">=18"
}
}
2 changes: 1 addition & 1 deletion packages/metro-config/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,6 @@
"strip-ansi": "^6.0.0"
},
"engines": {
"node": ">=16"
"node": ">=18"
}
}
2 changes: 1 addition & 1 deletion packages/metro-core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@
},
"license": "MIT",
"engines": {
"node": ">=16"
"node": ">=18"
}
}
2 changes: 1 addition & 1 deletion packages/metro-file-map/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,6 @@
"fsevents": "^2.3.2"
},
"engines": {
"node": ">=16"
"node": ">=18"
}
}
2 changes: 1 addition & 1 deletion packages/metro-inspector-proxy/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,6 @@
"node-fetch": "^2.2.0"
},
"engines": {
"node": ">=16"
"node": ">=18"
}
}
2 changes: 1 addition & 1 deletion packages/metro-memory-fs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@
},
"license": "MIT",
"engines": {
"node": ">=16"
"node": ">=18"
}
}
2 changes: 1 addition & 1 deletion packages/metro-minify-terser/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@
"terser": "^5.15.0"
},
"engines": {
"node": ">=16"
"node": ">=18"
}
}
2 changes: 1 addition & 1 deletion packages/metro-minify-uglify/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@
"uglify-es": "^3.1.9"
},
"engines": {
"node": ">=16"
"node": ">=18"
}
}
2 changes: 1 addition & 1 deletion packages/metro-react-native-babel-preset/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,6 @@
"@babel/core": "*"
},
"engines": {
"node": ">=16"
"node": ">=18"
}
}
2 changes: 1 addition & 1 deletion packages/metro-react-native-babel-transformer/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,6 @@
"@babel/core": "*"
},
"engines": {
"node": ">=16"
"node": ">=18"
}
}
2 changes: 1 addition & 1 deletion packages/metro-react-native-interop-tools/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@
},
"license": "MIT",
"engines": {
"node": ">=16"
"node": ">=18"
}
}
2 changes: 1 addition & 1 deletion packages/metro-resolver/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@
},
"license": "MIT",
"engines": {
"node": ">=16"
"node": ">=18"
}
}
2 changes: 1 addition & 1 deletion packages/metro-runtime/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,6 @@
"react-test-renderer": "^18.2.0"
},
"engines": {
"node": ">=16"
"node": ">=18"
}
}
2 changes: 1 addition & 1 deletion packages/metro-source-map/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,6 @@
"terser": "^5.15.0"
},
"engines": {
"node": ">=16"
"node": ">=18"
}
}
2 changes: 1 addition & 1 deletion packages/metro-symbolicate/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,6 @@
"vlq": "^1.0.0"
},
"engines": {
"node": ">=16"
"node": ">=18"
}
}
2 changes: 1 addition & 1 deletion packages/metro-transform-plugins/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,6 @@
"metro": "0.76.7"
},
"engines": {
"node": ">=16"
"node": ">=18"
}
}
2 changes: 1 addition & 1 deletion packages/metro-transform-worker/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,6 @@
"metro-react-native-babel-transformer": "0.76.7"
},
"engines": {
"node": ">=16"
"node": ">=18"
}
}
2 changes: 1 addition & 1 deletion packages/metro/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,6 @@
},
"license": "MIT",
"engines": {
"node": ">=16"
"node": ">=18"
}
}
2 changes: 1 addition & 1 deletion packages/ob1/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@
"license": "MIT",
"dependencies": {},
"engines": {
"node": ">=16"
"node": ">=18"
}
}
2 changes: 1 addition & 1 deletion tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "@tsconfig/node16/tsconfig.json",
"extends": "@tsconfig/node18/tsconfig.json",
"include": ["./packages/*/types/**/*.d.ts"],
"compilerOptions": {
"noEmit": true,
Expand Down
6 changes: 3 additions & 3 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1226,10 +1226,10 @@
dependencies:
"@sinonjs/commons" "^1.7.0"

"@tsconfig/node16@1.0.1":
"@tsconfig/node18@1.0.1":
version "1.0.1"
resolved "https://registry.yarnpkg.com/@tsconfig/node16/-/node16-1.0.1.tgz#a6ca6a9a0ff366af433f42f5f0e124794ff6b8f1"
integrity sha512-FTgBI767POY/lKNDNbIzgAX6miIDBs6NTCbdlDb8TrWovHsSvaVIZDlTqym29C6UqhzwcJx4CYr+AlrMywA0cA==
resolved "https://registry.yarnpkg.com/@tsconfig/node18/-/node18-1.0.1.tgz#ea5b375a9ead6b09ccbd70c3894ea069829ea1bb"
integrity sha512-sNFeK6X2ATlhlvzyH4kKYQlfHXE2f2/wxtB9ClvYXevWpmwkUT7VaSrjIN9E76Qebz8qP5JOJJ9jD3QoD/Z9TA==

"@types/babel__core@^7.1.14":
version "7.1.19"
Expand Down

0 comments on commit ebaf27a

Please sign in to comment.