Commits on Sep 15, 2023

1. Fix bug in symlink traversal with indirect targets …

   Summary:
   Fixes a bug where symlinks beginning with indirections (`../`) may fail to traverse in some `projectRoot` / `watchFolders` configurations.
   
   This occurs due to incomplete "normalisation" of a symlink target in `metro-file-map`, relative to the project root. Given a project root of `/project` and a symlink `/project/src/link-to-foo  -> ../../project/foo.js`, we would normalise the target to `../project/foo.js` rather than simply `foo.js` - we were not taking into account that further normalisation could be possible after joining with `projectRoot`.
   
   "Normal" paths are defined as being *fully* normalised relative to the project root. The unnecessary indirection out and back into the project root fails because `TreeFS` is a DAG, and internally there is no entry for `rootNode.get('..').get('project')` - this would be a cycle back to `rootNode`.
   
   Changelog:
   ```
    * **[Fix]:** Symlinks with indirections may not be resolvable
   ```
   
   Differential Revision: D49323614

   

   robhogan authored and facebook-github-bot committed Sep 15, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 0d927b5
   • Browse repository at this point

   Copy the full SHA

   0d927b5 View commit details

   Browse the repository at this point in the history