Add customizeFrame symbolicator config option #435
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewed By: cpojer Differential Revision: D16499755 fbshipit-source-id: 8c8fdb8ba97b07663fa7aac3e5a74b9627684da4
facebook-github-bot
added
the
CLA Signed
Codecov Report
@@ Coverage Diff @@
## master #435 +/- ##
==========================================
+ Coverage 84.83% 84.84% +0.01%
==========================================
Files 195 195
Lines 6424 6429 +5
Branches 1011 1012 +1
==========================================
+ Hits 5450 5455 +5
Misses 864 864
Partials 110 110
Continue to review full report at Codecov.
|
|
This pull request has been merged in 6517ca2. |
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Oct 10, 2019
Summary: Removes the use of `framesToPop` to manage frame skipping in YellowBox and replaces it with support for the `collapse` field populated by Metro's [`customizeFrame`](facebook/metro#435) config option. `framesToPop` is a deprecated mechanism which will be removed in the future. Reviewed By: bvaughn Differential Revision: D17857057 fbshipit-source-id: 120383ba4aad877b7ca79c7cf9d5b7579a490577
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
symbolicator.customizeFrameconfig option to Metro. This is a function that receives a symbolicated stack frame and can modify the response before it's sent back to the client. Thecollapsefield is the first supported customization, intended for auto-collapsing "internal" or infra-related stack frames.This is a redesign of work done originally in facebook/react-native#24662; I intend to eventually remove the client-side regex from RN.
Reviewed By: cpojer
Differential Revision: D16499755