metro-minify-terser: Don't mutate input options #929
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Mitigates terser/terser#1341 Terser sets properties inlcuding `source_map` and `_destroy_ast` on the given `options.output` (or `options.format`) object, which can affect subsequent calls where we re-use the same config object. Here we take a shallow copy of the given configuration, so `terser` doesn't mutate `metro-minify-terser`'s input. Changelog: [Fix] Mitigate potential source map mismatches with concurrent transformations (Terser [facebook#1341](terser/terser#1341)) Reviewed By: jacdebug, motiz88 Differential Revision: D43362977 fbshipit-source-id: 019f417aa8cc7897c71a6ab2c7db5d0cf916e59d
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D43362977 |
|
Merged in 5e27b3b |
This was referenced Mar 9, 2023
Closed
This was referenced Jul 30, 2023
This was referenced Aug 7, 2023
This was referenced Sep 26, 2023
This was referenced Jun 12, 2024
This was referenced Jun 22, 2024
This was referenced Aug 25, 2024
This was referenced Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Mitigates terser/terser#1341
Terser sets properties inlcuding
source_mapand_destroy_aston the givenoptions.output(oroptions.format) object, which can affect subsequent calls where we re-use the same config object.Here we take a shallow copy of the given configuration, so
terserdoesn't mutatemetro-minify-terser's input.Changelog: [Fix] Mitigate potential source map mismatches with concurrent transformations (Terser #1341)
Reviewed By: jacdebug, motiz88
Differential Revision: D43362977