Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support x_google_ignoreList in source map infra #973

Closed
wants to merge 1 commit into from

Commits on Apr 25, 2023

  1. Support x_google_ignoreList in source map infra (facebook#973)

    Summary:
    Pull Request resolved: facebook#973
    
    Changelog:
    * **[Feature]**: Basic support for `x_google_ignoreList` in `metro-source-map` and `metro-symbolicate`
    
    Enables Metro's source map infrastructure to produce and consume the `x_google_ignoreList` field, documented [here](https://developer.chrome.com/blog/devtools-better-angular-debugging/#the-x_google_ignorelist-source-map-extension).
    
    An upcoming diff will use this infra support to add ignore lists to Metro's source maps by default.
    
    The changes here include:
    
    * An option to mark source files as ignored in `metro-source-map`'s `Generator` (used by the serializer).
    * Preserving ignore lists in `composeSourceMaps`. `composeSourceMaps` is used by React Native in [OSS](https://github.com/facebook/react-native/blob/c1304d938da9cd5016da0bded4d618c42efbd7e4/scripts/compose-source-maps.js#L13) to generate source maps for Hermes bytecode compiled from Metro bundles.
    * Including an `isIgnored` field in source locations returned via the `metro-symbolicate` API. `metro-symbolicate` is the reference implementation of symbolication based on Metro's source maps.
    
    Reviewed By: GijsWeterings
    
    Differential Revision: D43554204
    
    fbshipit-source-id: f49f65827ccb1d346eec192c81c53e39597025ab
    motiz88 authored and facebook-github-bot committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    10b7019 View commit details
    Browse the repository at this point in the history