Don't clear the readBuffer when sending a RESET_STREAM frame

Summary: When we are sending a reset, we shouldn't clear out the read buffer because resets are a unidirectional event. Reviewed By: hanidamlaj Differential Revision: D66135577 fbshipit-source-id: ef388954f7c427017a1fa676d67ac80f3d001091
facebook · Nov 19, 2024 · 0dca9fb · 0dca9fb
1 parent 6b50bb6
commit 0dca9fb
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/quic/state/stream/StreamStateFunctions.cpp b/quic/state/stream/StreamStateFunctions.cpp
@@ -16,7 +16,6 @@ void resetQuicStream(QuicStreamState& stream, ApplicationErrorCode error) {
   stream.retransmissionBuffer.clear();
   stream.writeBuffer.move();
   ChainedByteRangeHead(std::move(stream.pendingWrites)); // Will be destructed
-  stream.readBuffer.clear();
   stream.lossBuffer.clear();
   stream.streamWriteError = error;
   stream.writeBufMeta.length = 0;

diff --git a/quic/state/stream/test/StreamStateFunctionsTest.cpp b/quic/state/stream/test/StreamStateFunctionsTest.cpp
@@ -50,7 +50,7 @@ TEST_F(StreamStateFunctionsTests, BasicResetTest) {
   // Something are cleared:
   EXPECT_TRUE(stream.writeBuffer.empty());
   EXPECT_TRUE(stream.retransmissionBuffer.empty());
-  EXPECT_TRUE(stream.readBuffer.empty());
+  EXPECT_FALSE(stream.readBuffer.empty());
 
   // The rest are untouched:
   EXPECT_EQ(stream.id, streamId);