Paramatized rust_static_library to enable CXX support #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D50772544 |
jdelliot
force-pushed
the
export-D50772544
branch
from
b642b70
to
76895e3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50772544 |
Summary: X-link: facebookincubator/delos_core#8 X-link: facebookincubator/zstrong#610 X-link: facebookincubator/crux#10 X-link: facebookexternal/traffixr#3 X-link: facebookincubator/katran#205 X-link: facebookincubator/fizz#101 X-link: facebook/sapling#763 X-link: facebookexperimental/rust-shed#43 X-link: facebook/wangle#221 X-link: facebook/openr#150 X-link: facebook/hhvm#9403 X-link: facebook/folly#2092 X-link: facebook/fb303#42 X-link: facebookincubator/velox#7301 We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path. Reviewed By: xavierd Differential Revision: D50772544
jdelliot
force-pushed
the
export-D50772544
branch
from
76895e3
to
967f87c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50772544 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebook/folly#2092
X-link: facebook/fb303#42
X-link: facebookincubator/velox#7301
We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option,
USE_CXX_INCLUDE, to the CMake function,rust_static_library, to enable adding thecxxbridgepath to the include path.Differential Revision: D50772544