Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAVEPOINT support #52

Open
hermanlee opened this issue Sep 28, 2015 · 3 comments
Open

SAVEPOINT support #52

hermanlee opened this issue Sep 28, 2015 · 3 comments
Assignees
@spetrunia
Labels
enhancement mid-pri myrocks

Comments

@hermanlee
Copy link
Contributor

Issue by yoshinorim
Friday Aug 14, 2015 at 15:03 GMT
Originally opened as MySQLOnRocksDB#96

SAVEPOINT is needed for https://bugs.mysql.com/bug.php?id=71017. For bug71017, SAVEPOINT for read only transaction is good enough. It is needed to define behavior if there is any updates.

  • Supporting real SAVEPOINT (rolling back to the savepoint if executing ROLLBACK TO SAVEPOINT).
  • Returning errors if there is any modification after or at executing SAVEPOINT.
@hermanlee
Copy link
Contributor Author

Comment by yoshinorim
Monday Aug 17, 2015 at 17:23 GMT

First diff was committed -- https://reviews.facebook.net/D44223 . This is for read only transactions (mysqldump) only, and there is no error handling on modifications.

@yoshinorim
Copy link
Contributor

Current behavior is very confusing because ROLLBACK TO SAVEPOINT silently succeeds but it doesn't rollback modifications. We need either:

  1. Real SAVEPOINT support (rollback)
  2. Returning errors on ROLLBACK TO SAVEPOINT if there is any modification. This is ok to make mysqldump work.

yoshinorim added a commit that referenced this issue Jan 25, 2016
@yoshinorim
MyRocks: Returning an error on ROLLBACK TO SAVEPOINT if modifying rows (
b7bf6ac 
#52)

Summary:
MyRocks did neither rollback nor return an error on ROLLBACK TO
SAVEPOINT, which was confusing to users. This diff makes MyRocks return
an error on ROLLBACK TO SAVEPOINT if modifying rows. Users can
at least know that.
Real fix is to support rollback on savepoint, not to return an error,
which will happen in future release.

Test Plan: mtr

Reviewers: hermanlee4, jkedgar, spetrunia

Subscribers: webscalesql-eng

Differential Revision: https://reviews.facebook.net/D53055
@yoshinorim
Copy link
Contributor

Now modification is not allowed --- https://reviews.facebook.net/D53055 . This makes ROLLBACK TO SAVEPOINT less confusing.

@spetrunia spetrunia self-assigned this Mar 15, 2016
hermanlee pushed a commit that referenced this issue Jan 31, 2017
@yoshinorim
MyRocks: Returning an error on ROLLBACK TO SAVEPOINT if modifying rows (
12a6988 
#52)

Summary:
MyRocks did neither rollback nor return an error on ROLLBACK TO
SAVEPOINT, which was confusing to users. This diff makes MyRocks return
an error on ROLLBACK TO SAVEPOINT if modifying rows. Users can
at least know that.
Real fix is to support rollback on savepoint, not to return an error,
which will happen in future release.

Test Plan: mtr

Reviewers: hermanlee4, jkedgar, spetrunia

Subscribers: webscalesql-eng

Differential Revision: https://reviews.facebook.net/D53055
Differential Revision: https://reviews.facebook.net/D55011
Differential Revision: https://reviews.facebook.net/D55161
VitaliyLi pushed a commit to VitaliyLi/mysql-5.6 that referenced this issue Feb 9, 2017
@yoshinorim @jkedgar
MyRocks: Returning an error on ROLLBACK TO SAVEPOINT if modifying rows (
c00fa75 
facebook#52)

Summary:
MyRocks did neither rollback nor return an error on ROLLBACK TO
SAVEPOINT, which was confusing to users. This diff makes MyRocks return
an error on ROLLBACK TO SAVEPOINT if modifying rows. Users can
at least know that.
Real fix is to support rollback on savepoint, not to return an error,
which will happen in future release.

Test Plan: mtr

Reviewers: hermanlee4, jkedgar, spetrunia

Subscribers: webscalesql-eng

Differential Revision: https://reviews.facebook.net/D53055
Differential Revision: https://reviews.facebook.net/D55011
Differential Revision: https://reviews.facebook.net/D55161
facebook-github-bot pushed a commit that referenced this issue Dec 23, 2019
@yoshinorim @facebook-github-bot
MyRocks: Returning an error on ROLLBACK TO SAVEPOINT if modifying rows (
2225dcc 
#52)

Summary:
MyRocks did neither rollback nor return an error on ROLLBACK TO
SAVEPOINT, which was confusing to users. This diff makes MyRocks return
an error on ROLLBACK TO SAVEPOINT if modifying rows. Users can
at least know that.
Real fix is to support rollback on savepoint, not to return an error,
which will happen in future release.

Differential Revision: https://reviews.facebook.net/D55161

fbshipit-source-id: 0178a1e
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue Aug 12, 2020
@yoshinorim @inikep
MyRocks: Returning an error on ROLLBACK TO SAVEPOINT if modifying rows (
1d6136a 
facebook#52)

Summary:
MyRocks did neither rollback nor return an error on ROLLBACK TO
SAVEPOINT, which was confusing to users. This diff makes MyRocks return
an error on ROLLBACK TO SAVEPOINT if modifying rows. Users can
at least know that.
Real fix is to support rollback on savepoint, not to return an error,
which will happen in future release.

Differential Revision: https://reviews.facebook.net/D55161

fbshipit-source-id: 0178a1e
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue Sep 9, 2020
@yoshinorim @inikep
MyRocks: Returning an error on ROLLBACK TO SAVEPOINT if modifying rows (
cabd51a 
facebook#52)

Summary:
MyRocks did neither rollback nor return an error on ROLLBACK TO
SAVEPOINT, which was confusing to users. This diff makes MyRocks return
an error on ROLLBACK TO SAVEPOINT if modifying rows. Users can
at least know that.
Real fix is to support rollback on savepoint, not to return an error,
which will happen in future release.

Differential Revision: https://reviews.facebook.net/D55161

fbshipit-source-id: 0178a1e
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue Sep 16, 2020
@yoshinorim @inikep
MyRocks: Returning an error on ROLLBACK TO SAVEPOINT if modifying rows (
a74f727 
facebook#52)

Summary:
MyRocks did neither rollback nor return an error on ROLLBACK TO
SAVEPOINT, which was confusing to users. This diff makes MyRocks return
an error on ROLLBACK TO SAVEPOINT if modifying rows. Users can
at least know that.
Real fix is to support rollback on savepoint, not to return an error,
which will happen in future release.

Differential Revision: https://reviews.facebook.net/D55161

fbshipit-source-id: 0178a1e
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue Oct 5, 2020
@yoshinorim @inikep
MyRocks: Returning an error on ROLLBACK TO SAVEPOINT if modifying rows (
9c982d5 
facebook#52)

Summary:
MyRocks did neither rollback nor return an error on ROLLBACK TO
SAVEPOINT, which was confusing to users. This diff makes MyRocks return
an error on ROLLBACK TO SAVEPOINT if modifying rows. Users can
at least know that.
Real fix is to support rollback on savepoint, not to return an error,
which will happen in future release.

Differential Revision: https://reviews.facebook.net/D55161

fbshipit-source-id: 0178a1e
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue Nov 11, 2020
@yoshinorim @inikep
MyRocks: Returning an error on ROLLBACK TO SAVEPOINT if modifying rows (
e0744fa 
facebook#52)

Summary:
MyRocks did neither rollback nor return an error on ROLLBACK TO
SAVEPOINT, which was confusing to users. This diff makes MyRocks return
an error on ROLLBACK TO SAVEPOINT if modifying rows. Users can
at least know that.
Real fix is to support rollback on savepoint, not to return an error,
which will happen in future release.

Differential Revision: https://reviews.facebook.net/D55161

fbshipit-source-id: 0178a1e
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue Mar 11, 2021
@yoshinorim @facebook-github-bot
MyRocks: Returning an error on ROLLBACK TO SAVEPOINT if modifying rows (
290cc69 
facebook#52)

Summary:
MyRocks did neither rollback nor return an error on ROLLBACK TO
SAVEPOINT, which was confusing to users. This diff makes MyRocks return
an error on ROLLBACK TO SAVEPOINT if modifying rows. Users can
at least know that.
Real fix is to support rollback on savepoint, not to return an error,
which will happen in future release.

Differential Revision: https://reviews.facebook.net/D55161

fbshipit-source-id: 228f0131f26
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue Aug 16, 2021
@yoshinorim @inikep
MyRocks: Returning an error on ROLLBACK TO SAVEPOINT if modifying rows (
da971bd 
facebook#52)

Summary:
MyRocks did neither rollback nor return an error on ROLLBACK TO
SAVEPOINT, which was confusing to users. This diff makes MyRocks return
an error on ROLLBACK TO SAVEPOINT if modifying rows. Users can
at least know that.
Real fix is to support rollback on savepoint, not to return an error,
which will happen in future release.

Differential Revision: https://reviews.facebook.net/D55161

fbshipit-source-id: 228f0131f26
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue Aug 30, 2021
@yoshinorim @inikep
MyRocks: Returning an error on ROLLBACK TO SAVEPOINT if modifying rows (
371628f 
facebook#52)

Summary:
MyRocks did neither rollback nor return an error on ROLLBACK TO
SAVEPOINT, which was confusing to users. This diff makes MyRocks return
an error on ROLLBACK TO SAVEPOINT if modifying rows. Users can
at least know that.
Real fix is to support rollback on savepoint, not to return an error,
which will happen in future release.

Differential Revision: https://reviews.facebook.net/D55161

fbshipit-source-id: 228f0131f26
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue Aug 30, 2021
@yoshinorim @inikep
MyRocks: Returning an error on ROLLBACK TO SAVEPOINT if modifying rows (
02256d2 
facebook#52)

Summary:
MyRocks did neither rollback nor return an error on ROLLBACK TO
SAVEPOINT, which was confusing to users. This diff makes MyRocks return
an error on ROLLBACK TO SAVEPOINT if modifying rows. Users can
at least know that.
Real fix is to support rollback on savepoint, not to return an error,
which will happen in future release.

Differential Revision: https://reviews.facebook.net/D55161

fbshipit-source-id: 228f0131f26
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue Sep 1, 2021
@yoshinorim @inikep
MyRocks: Returning an error on ROLLBACK TO SAVEPOINT if modifying rows (
8b6e889 
facebook#52)

Summary:
MyRocks did neither rollback nor return an error on ROLLBACK TO
SAVEPOINT, which was confusing to users. This diff makes MyRocks return
an error on ROLLBACK TO SAVEPOINT if modifying rows. Users can
at least know that.
Real fix is to support rollback on savepoint, not to return an error,
which will happen in future release.

Differential Revision: https://reviews.facebook.net/D55161

fbshipit-source-id: 228f0131f26
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue Sep 2, 2021
@yoshinorim @inikep
MyRocks: Returning an error on ROLLBACK TO SAVEPOINT if modifying rows (
4bac43d 
facebook#52)

Summary:
MyRocks did neither rollback nor return an error on ROLLBACK TO
SAVEPOINT, which was confusing to users. This diff makes MyRocks return
an error on ROLLBACK TO SAVEPOINT if modifying rows. Users can
at least know that.
Real fix is to support rollback on savepoint, not to return an error,
which will happen in future release.

Differential Revision: https://reviews.facebook.net/D55161

fbshipit-source-id: 228f0131f26
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue Jan 17, 2022
@yoshinorim @inikep
MyRocks: Returning an error on ROLLBACK TO SAVEPOINT if modifying rows (
d8bea41 
facebook#52)

Summary:
MyRocks did neither rollback nor return an error on ROLLBACK TO
SAVEPOINT, which was confusing to users. This diff makes MyRocks return
an error on ROLLBACK TO SAVEPOINT if modifying rows. Users can
at least know that.
Real fix is to support rollback on savepoint, not to return an error,
which will happen in future release.

Differential Revision: https://reviews.facebook.net/D55161
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue Apr 26, 2022
@yoshinorim
MyRocks: Returning an error on ROLLBACK TO SAVEPOINT if modifying rows (
61ae677 
facebook#52)

Summary:
MyRocks did neither rollback nor return an error on ROLLBACK TO
SAVEPOINT, which was confusing to users. This diff makes MyRocks return
an error on ROLLBACK TO SAVEPOINT if modifying rows. Users can
at least know that.
Real fix is to support rollback on savepoint, not to return an error,
which will happen in future release.

Differential Revision: https://reviews.facebook.net/D55161
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue May 20, 2022
@yoshinorim @inikep
MyRocks: Returning an error on ROLLBACK TO SAVEPOINT if modifying rows (
6f3e80e 
facebook#52)

Summary:
MyRocks did neither rollback nor return an error on ROLLBACK TO
SAVEPOINT, which was confusing to users. This diff makes MyRocks return
an error on ROLLBACK TO SAVEPOINT if modifying rows. Users can
at least know that.
Real fix is to support rollback on savepoint, not to return an error,
which will happen in future release.

Differential Revision: https://reviews.facebook.net/D55161
laurynas-biveinis pushed a commit to laurynas-biveinis/mysql-5.6 that referenced this issue Aug 11, 2022
@yoshinorim
MyRocks: Returning an error on ROLLBACK TO SAVEPOINT if modifying rows (
6f9d40b 
facebook#52)

Summary:
MyRocks did neither rollback nor return an error on ROLLBACK TO
SAVEPOINT, which was confusing to users. This diff makes MyRocks return
an error on ROLLBACK TO SAVEPOINT if modifying rows. Users can
at least know that.
Real fix is to support rollback on savepoint, not to return an error,
which will happen in future release.

Differential Revision: https://reviews.facebook.net/D55161
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue Mar 28, 2023
@yoshinorim @inikep
MyRocks: Returning an error on ROLLBACK TO SAVEPOINT if modifying rows (
e1b5687 
facebook#52)

Summary:
MyRocks did neither rollback nor return an error on ROLLBACK TO
SAVEPOINT, which was confusing to users. This diff makes MyRocks return
an error on ROLLBACK TO SAVEPOINT if modifying rows. Users can
at least know that.
Real fix is to support rollback on savepoint, not to return an error,
which will happen in future release.

Differential Revision: https://reviews.facebook.net/D55161
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue Jun 1, 2023
@yoshinorim @inikep
MyRocks: Returning an error on ROLLBACK TO SAVEPOINT if modifying rows (
4c9790d 
facebook#52)

Summary:
MyRocks did neither rollback nor return an error on ROLLBACK TO
SAVEPOINT, which was confusing to users. This diff makes MyRocks return
an error on ROLLBACK TO SAVEPOINT if modifying rows. Users can
at least know that.
Real fix is to support rollback on savepoint, not to return an error,
which will happen in future release.

Differential Revision: https://reviews.facebook.net/D55161
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue Jun 14, 2023
@yoshinorim @inikep
MyRocks: Returning an error on ROLLBACK TO SAVEPOINT if modifying rows (
62d2c6d 
facebook#52)

Summary:
MyRocks did neither rollback nor return an error on ROLLBACK TO
SAVEPOINT, which was confusing to users. This diff makes MyRocks return
an error on ROLLBACK TO SAVEPOINT if modifying rows. Users can
at least know that.
Real fix is to support rollback on savepoint, not to return an error,
which will happen in future release.

Differential Revision: https://reviews.facebook.net/D55161
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spetrunia spetrunia

Labels
enhancement mid-pri myrocks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@yoshinorim @spetrunia @gunnarku @hermanlee