-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rdb_i_s_sst_props_fields_info #1267
Open
rockeet
wants to merge
3
commits into
facebook:fb-mysql-8.0.28
Choose a base branch
from
rockeet:fix-rdb_i_s_sst_props_fields_info
base: fb-mysql-8.0.28
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix rdb_i_s_sst_props_fields_info #1267
rockeet
wants to merge
3
commits into
facebook:fb-mysql-8.0.28
from
rockeet:fix-rdb_i_s_sst_props_fields_info
+8
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@hermanlee has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Thank you for the PR to fix this issue! |
@rockeet has updated the pull request. You must reimport the pull request before landing. |
@hermanlee has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 6, 2023
Summary: In `rdb_i_s_sst_props_fields_info` definition, flag `MY_I_S_MAYBE_NULL` is missing for fields `COMPRESSION_ALGO`, `FILTER_POLICY`, `COMPRESSION_OPTIONS`, causing the `set_null` does not take effect, these 3 fields will keep last SST's value. This PR fixed this issue. Pull Request resolved: #1267 Reviewed By: lth Differential Revision: D42928109 Pulled By: hermanlee fbshipit-source-id: 662dc11
alanliang
pushed a commit
to alanliang/mysql-5.6
that referenced
this pull request
Mar 4, 2023
Summary: In `rdb_i_s_sst_props_fields_info` definition, flag `MY_I_S_MAYBE_NULL` is missing for fields `COMPRESSION_ALGO`, `FILTER_POLICY`, `COMPRESSION_OPTIONS`, causing the `set_null` does not take effect, these 3 fields will keep last SST's value. This PR fixed this issue. Pull Request resolved: facebook#1267 GitHub Author: leipeng <peng@topling.cn> Test Plan: Imported from GitHub, without a `Test Plan:` line. Reviewers: luqun, rpan, mung, chni Reviewed By: mung Subscribers: webscalesql-eng@fb.com Differential Revision: https://phabricator.intern.facebook.com/D42928109 Tags: accept2ship
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
May 9, 2023
Upstream commit ID: facebook/mysql-5.6@8fae2bb PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: In `rdb_i_s_sst_props_fields_info` definition, flag `MY_I_S_MAYBE_NULL` is missing for fields `COMPRESSION_ALGO`, `FILTER_POLICY`, `COMPRESSION_OPTIONS`, causing the `set_null` does not take effect, these 3 fields will keep last SST's value. This PR fixed this issue. Pull Request resolved: facebook/mysql-5.6#1267 Reviewed By: lth Differential Revision: D42928109 Pulled By: hermanlee fbshipit-source-id: 662dc11e7c9a8f8c0758006e20ccc739ebe09f40
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
May 9, 2023
Upstream commit ID: facebook/mysql-5.6@8fae2bb PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: In `rdb_i_s_sst_props_fields_info` definition, flag `MY_I_S_MAYBE_NULL` is missing for fields `COMPRESSION_ALGO`, `FILTER_POLICY`, `COMPRESSION_OPTIONS`, causing the `set_null` does not take effect, these 3 fields will keep last SST's value. This PR fixed this issue. Pull Request resolved: facebook/mysql-5.6#1267 Reviewed By: lth Differential Revision: D42928109 Pulled By: hermanlee fbshipit-source-id: 662dc11e7c9a8f8c0758006e20ccc739ebe09f40
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
May 10, 2023
Upstream commit ID: facebook/mysql-5.6@8fae2bb PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: In `rdb_i_s_sst_props_fields_info` definition, flag `MY_I_S_MAYBE_NULL` is missing for fields `COMPRESSION_ALGO`, `FILTER_POLICY`, `COMPRESSION_OPTIONS`, causing the `set_null` does not take effect, these 3 fields will keep last SST's value. This PR fixed this issue. Pull Request resolved: facebook/mysql-5.6#1267 Reviewed By: lth Differential Revision: D42928109 Pulled By: hermanlee fbshipit-source-id: 662dc11e7c9a8f8c0758006e20ccc739ebe09f40
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 15, 2023
Summary: In `rdb_i_s_sst_props_fields_info` definition, flag `MY_I_S_MAYBE_NULL` is missing for fields `COMPRESSION_ALGO`, `FILTER_POLICY`, `COMPRESSION_OPTIONS`, causing the `set_null` does not take effect, these 3 fields will keep last SST's value. This PR fixed this issue. Pull Request resolved: facebook#1267 Reviewed By: lth Differential Revision: D42928109 Pulled By: hermanlee fbshipit-source-id: 662dc11
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 18, 2023
Summary: In `rdb_i_s_sst_props_fields_info` definition, flag `MY_I_S_MAYBE_NULL` is missing for fields `COMPRESSION_ALGO`, `FILTER_POLICY`, `COMPRESSION_OPTIONS`, causing the `set_null` does not take effect, these 3 fields will keep last SST's value. This PR fixed this issue. Pull Request resolved: facebook#1267 Reviewed By: lth Differential Revision: D42928109 Pulled By: hermanlee fbshipit-source-id: 662dc11
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 26, 2023
Summary: In `rdb_i_s_sst_props_fields_info` definition, flag `MY_I_S_MAYBE_NULL` is missing for fields `COMPRESSION_ALGO`, `FILTER_POLICY`, `COMPRESSION_OPTIONS`, causing the `set_null` does not take effect, these 3 fields will keep last SST's value. This PR fixed this issue. Pull Request resolved: facebook#1267 Reviewed By: lth Differential Revision: D42928109 Pulled By: hermanlee fbshipit-source-id: 662dc11
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 1, 2023
Summary: In `rdb_i_s_sst_props_fields_info` definition, flag `MY_I_S_MAYBE_NULL` is missing for fields `COMPRESSION_ALGO`, `FILTER_POLICY`, `COMPRESSION_OPTIONS`, causing the `set_null` does not take effect, these 3 fields will keep last SST's value. This PR fixed this issue. Pull Request resolved: facebook#1267 Reviewed By: lth Differential Revision: D42928109 Pulled By: hermanlee fbshipit-source-id: 662dc11
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 14, 2023
Summary: In `rdb_i_s_sst_props_fields_info` definition, flag `MY_I_S_MAYBE_NULL` is missing for fields `COMPRESSION_ALGO`, `FILTER_POLICY`, `COMPRESSION_OPTIONS`, causing the `set_null` does not take effect, these 3 fields will keep last SST's value. This PR fixed this issue. Pull Request resolved: facebook#1267 Reviewed By: lth Differential Revision: D42928109 Pulled By: hermanlee fbshipit-source-id: 662dc11
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Jun 27, 2023
Upstream commit ID: facebook/mysql-5.6@8fae2bb PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: In `rdb_i_s_sst_props_fields_info` definition, flag `MY_I_S_MAYBE_NULL` is missing for fields `COMPRESSION_ALGO`, `FILTER_POLICY`, `COMPRESSION_OPTIONS`, causing the `set_null` does not take effect, these 3 fields will keep last SST's value. This PR fixed this issue. Pull Request resolved: facebook/mysql-5.6#1267 Reviewed By: lth Differential Revision: D42928109 Pulled By: hermanlee fbshipit-source-id: 662dc11e7c9a8f8c0758006e20ccc739ebe09f40
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Jun 29, 2023
Upstream commit ID: facebook/mysql-5.6@8fae2bb PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: In `rdb_i_s_sst_props_fields_info` definition, flag `MY_I_S_MAYBE_NULL` is missing for fields `COMPRESSION_ALGO`, `FILTER_POLICY`, `COMPRESSION_OPTIONS`, causing the `set_null` does not take effect, these 3 fields will keep last SST's value. This PR fixed this issue. Pull Request resolved: facebook/mysql-5.6#1267 Reviewed By: lth Differential Revision: D42928109 Pulled By: hermanlee fbshipit-source-id: 662dc11e7c9a8f8c0758006e20ccc739ebe09f40
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Jul 18, 2023
Upstream commit ID: facebook/mysql-5.6@8fae2bb PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: In `rdb_i_s_sst_props_fields_info` definition, flag `MY_I_S_MAYBE_NULL` is missing for fields `COMPRESSION_ALGO`, `FILTER_POLICY`, `COMPRESSION_OPTIONS`, causing the `set_null` does not take effect, these 3 fields will keep last SST's value. This PR fixed this issue. Pull Request resolved: facebook/mysql-5.6#1267 Reviewed By: lth Differential Revision: D42928109 Pulled By: hermanlee fbshipit-source-id: 662dc11e7c9a8f8c0758006e20ccc739ebe09f40
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Jul 19, 2023
Upstream commit ID: facebook/mysql-5.6@8fae2bb PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: In `rdb_i_s_sst_props_fields_info` definition, flag `MY_I_S_MAYBE_NULL` is missing for fields `COMPRESSION_ALGO`, `FILTER_POLICY`, `COMPRESSION_OPTIONS`, causing the `set_null` does not take effect, these 3 fields will keep last SST's value. This PR fixed this issue. Pull Request resolved: facebook/mysql-5.6#1267 Reviewed By: lth Differential Revision: D42928109 Pulled By: hermanlee fbshipit-source-id: 662dc11e7c9a8f8c0758006e20ccc739ebe09f40
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Jul 24, 2023
Upstream commit ID: facebook/mysql-5.6@8fae2bb PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: In `rdb_i_s_sst_props_fields_info` definition, flag `MY_I_S_MAYBE_NULL` is missing for fields `COMPRESSION_ALGO`, `FILTER_POLICY`, `COMPRESSION_OPTIONS`, causing the `set_null` does not take effect, these 3 fields will keep last SST's value. This PR fixed this issue. Pull Request resolved: facebook/mysql-5.6#1267 Reviewed By: lth Differential Revision: D42928109 Pulled By: hermanlee fbshipit-source-id: 662dc11e7c9a8f8c0758006e20ccc739ebe09f40
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Jul 25, 2023
Upstream commit ID: facebook/mysql-5.6@8fae2bb PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: In `rdb_i_s_sst_props_fields_info` definition, flag `MY_I_S_MAYBE_NULL` is missing for fields `COMPRESSION_ALGO`, `FILTER_POLICY`, `COMPRESSION_OPTIONS`, causing the `set_null` does not take effect, these 3 fields will keep last SST's value. This PR fixed this issue. Pull Request resolved: facebook/mysql-5.6#1267 Reviewed By: lth Differential Revision: D42928109 Pulled By: hermanlee fbshipit-source-id: 662dc11e7c9a8f8c0758006e20ccc739ebe09f40
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Jul 26, 2023
Upstream commit ID: facebook/mysql-5.6@8fae2bb PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: In `rdb_i_s_sst_props_fields_info` definition, flag `MY_I_S_MAYBE_NULL` is missing for fields `COMPRESSION_ALGO`, `FILTER_POLICY`, `COMPRESSION_OPTIONS`, causing the `set_null` does not take effect, these 3 fields will keep last SST's value. This PR fixed this issue. Pull Request resolved: facebook/mysql-5.6#1267 Reviewed By: lth Differential Revision: D42928109 Pulled By: hermanlee fbshipit-source-id: 662dc11e7c9a8f8c0758006e20ccc739ebe09f40
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Jul 27, 2023
Upstream commit ID: facebook/mysql-5.6@8fae2bb PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: In `rdb_i_s_sst_props_fields_info` definition, flag `MY_I_S_MAYBE_NULL` is missing for fields `COMPRESSION_ALGO`, `FILTER_POLICY`, `COMPRESSION_OPTIONS`, causing the `set_null` does not take effect, these 3 fields will keep last SST's value. This PR fixed this issue. Pull Request resolved: facebook/mysql-5.6#1267 Reviewed By: lth Differential Revision: D42928109 Pulled By: hermanlee fbshipit-source-id: 662dc11e7c9a8f8c0758006e20ccc739ebe09f40
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Aug 1, 2023
Upstream commit ID: facebook/mysql-5.6@8fae2bb PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: In `rdb_i_s_sst_props_fields_info` definition, flag `MY_I_S_MAYBE_NULL` is missing for fields `COMPRESSION_ALGO`, `FILTER_POLICY`, `COMPRESSION_OPTIONS`, causing the `set_null` does not take effect, these 3 fields will keep last SST's value. This PR fixed this issue. Pull Request resolved: facebook/mysql-5.6#1267 Reviewed By: lth Differential Revision: D42928109 Pulled By: hermanlee fbshipit-source-id: 662dc11e7c9a8f8c0758006e20ccc739ebe09f40
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Aug 14, 2023
Upstream commit ID: facebook/mysql-5.6@8fae2bb PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: In `rdb_i_s_sst_props_fields_info` definition, flag `MY_I_S_MAYBE_NULL` is missing for fields `COMPRESSION_ALGO`, `FILTER_POLICY`, `COMPRESSION_OPTIONS`, causing the `set_null` does not take effect, these 3 fields will keep last SST's value. This PR fixed this issue. Pull Request resolved: facebook/mysql-5.6#1267 Reviewed By: lth Differential Revision: D42928109 Pulled By: hermanlee fbshipit-source-id: 662dc11e7c9a8f8c0758006e20ccc739ebe09f40
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Aug 24, 2023
Upstream commit ID: facebook/mysql-5.6@8fae2bb PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: In `rdb_i_s_sst_props_fields_info` definition, flag `MY_I_S_MAYBE_NULL` is missing for fields `COMPRESSION_ALGO`, `FILTER_POLICY`, `COMPRESSION_OPTIONS`, causing the `set_null` does not take effect, these 3 fields will keep last SST's value. This PR fixed this issue. Pull Request resolved: facebook/mysql-5.6#1267 Reviewed By: lth Differential Revision: D42928109 Pulled By: hermanlee fbshipit-source-id: 662dc11e7c9a8f8c0758006e20ccc739ebe09f40
inikep
pushed a commit
to percona/percona-server
that referenced
this pull request
Sep 15, 2023
Upstream commit ID: facebook/mysql-5.6@8fae2bb PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: In `rdb_i_s_sst_props_fields_info` definition, flag `MY_I_S_MAYBE_NULL` is missing for fields `COMPRESSION_ALGO`, `FILTER_POLICY`, `COMPRESSION_OPTIONS`, causing the `set_null` does not take effect, these 3 fields will keep last SST's value. This PR fixed this issue. Pull Request resolved: facebook/mysql-5.6#1267 Reviewed By: lth Differential Revision: D42928109 Pulled By: hermanlee fbshipit-source-id: 662dc11e7c9a8f8c0758006e20ccc739ebe09f40
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Apr 16, 2024
Upstream commit ID: facebook/mysql-5.6@8fae2bb PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: In `rdb_i_s_sst_props_fields_info` definition, flag `MY_I_S_MAYBE_NULL` is missing for fields `COMPRESSION_ALGO`, `FILTER_POLICY`, `COMPRESSION_OPTIONS`, causing the `set_null` does not take effect, these 3 fields will keep last SST's value. This PR fixed this issue. Pull Request resolved: facebook/mysql-5.6#1267 Reviewed By: lth Differential Revision: D42928109 Pulled By: hermanlee fbshipit-source-id: 662dc11e7c9a8f8c0758006e20ccc739ebe09f40
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Apr 16, 2024
Upstream commit ID: facebook/mysql-5.6@8fae2bb PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: In `rdb_i_s_sst_props_fields_info` definition, flag `MY_I_S_MAYBE_NULL` is missing for fields `COMPRESSION_ALGO`, `FILTER_POLICY`, `COMPRESSION_OPTIONS`, causing the `set_null` does not take effect, these 3 fields will keep last SST's value. This PR fixed this issue. Pull Request resolved: facebook/mysql-5.6#1267 Reviewed By: lth Differential Revision: D42928109 Pulled By: hermanlee fbshipit-source-id: 662dc11e7c9a8f8c0758006e20ccc739ebe09f40
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Apr 16, 2024
Upstream commit ID: facebook/mysql-5.6@8fae2bb PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: In `rdb_i_s_sst_props_fields_info` definition, flag `MY_I_S_MAYBE_NULL` is missing for fields `COMPRESSION_ALGO`, `FILTER_POLICY`, `COMPRESSION_OPTIONS`, causing the `set_null` does not take effect, these 3 fields will keep last SST's value. This PR fixed this issue. Pull Request resolved: facebook/mysql-5.6#1267 Reviewed By: lth Differential Revision: D42928109 Pulled By: hermanlee fbshipit-source-id: 662dc11e7c9a8f8c0758006e20ccc739ebe09f40
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Apr 16, 2024
Upstream commit ID: facebook/mysql-5.6@8fae2bb PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: In `rdb_i_s_sst_props_fields_info` definition, flag `MY_I_S_MAYBE_NULL` is missing for fields `COMPRESSION_ALGO`, `FILTER_POLICY`, `COMPRESSION_OPTIONS`, causing the `set_null` does not take effect, these 3 fields will keep last SST's value. This PR fixed this issue. Pull Request resolved: facebook/mysql-5.6#1267 Reviewed By: lth Differential Revision: D42928109 Pulled By: hermanlee fbshipit-source-id: 662dc11e7c9a8f8c0758006e20ccc739ebe09f40
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Apr 16, 2024
Upstream commit ID: facebook/mysql-5.6@8fae2bb PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: In `rdb_i_s_sst_props_fields_info` definition, flag `MY_I_S_MAYBE_NULL` is missing for fields `COMPRESSION_ALGO`, `FILTER_POLICY`, `COMPRESSION_OPTIONS`, causing the `set_null` does not take effect, these 3 fields will keep last SST's value. This PR fixed this issue. Pull Request resolved: facebook/mysql-5.6#1267 Reviewed By: lth Differential Revision: D42928109 Pulled By: hermanlee fbshipit-source-id: 662dc11e7c9a8f8c0758006e20ccc739ebe09f40
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Apr 18, 2024
Upstream commit ID: facebook/mysql-5.6@8fae2bb PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: In `rdb_i_s_sst_props_fields_info` definition, flag `MY_I_S_MAYBE_NULL` is missing for fields `COMPRESSION_ALGO`, `FILTER_POLICY`, `COMPRESSION_OPTIONS`, causing the `set_null` does not take effect, these 3 fields will keep last SST's value. This PR fixed this issue. Pull Request resolved: facebook/mysql-5.6#1267 Reviewed By: lth Differential Revision: D42928109 Pulled By: hermanlee fbshipit-source-id: 662dc11e7c9a8f8c0758006e20ccc739ebe09f40
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Apr 29, 2024
Upstream commit ID: facebook/mysql-5.6@8fae2bb PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: In `rdb_i_s_sst_props_fields_info` definition, flag `MY_I_S_MAYBE_NULL` is missing for fields `COMPRESSION_ALGO`, `FILTER_POLICY`, `COMPRESSION_OPTIONS`, causing the `set_null` does not take effect, these 3 fields will keep last SST's value. This PR fixed this issue. Pull Request resolved: facebook/mysql-5.6#1267 Reviewed By: lth Differential Revision: D42928109 Pulled By: hermanlee fbshipit-source-id: 662dc11e7c9a8f8c0758006e20ccc739ebe09f40
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 7, 2024
Summary: In `rdb_i_s_sst_props_fields_info` definition, flag `MY_I_S_MAYBE_NULL` is missing for fields `COMPRESSION_ALGO`, `FILTER_POLICY`, `COMPRESSION_OPTIONS`, causing the `set_null` does not take effect, these 3 fields will keep last SST's value. This PR fixed this issue. Pull Request resolved: facebook#1267 Reviewed By: lth Differential Revision: D42928109 Pulled By: hermanlee
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
May 13, 2024
Upstream commit ID: facebook/mysql-5.6@8fae2bb PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: In `rdb_i_s_sst_props_fields_info` definition, flag `MY_I_S_MAYBE_NULL` is missing for fields `COMPRESSION_ALGO`, `FILTER_POLICY`, `COMPRESSION_OPTIONS`, causing the `set_null` does not take effect, these 3 fields will keep last SST's value. This PR fixed this issue. Pull Request resolved: facebook/mysql-5.6#1267 Reviewed By: lth Differential Revision: D42928109 Pulled By: hermanlee fbshipit-source-id: 662dc11e7c9a8f8c0758006e20ccc739ebe09f40
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
May 24, 2024
Upstream commit ID: facebook/mysql-5.6@8fae2bb PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: In `rdb_i_s_sst_props_fields_info` definition, flag `MY_I_S_MAYBE_NULL` is missing for fields `COMPRESSION_ALGO`, `FILTER_POLICY`, `COMPRESSION_OPTIONS`, causing the `set_null` does not take effect, these 3 fields will keep last SST's value. This PR fixed this issue. Pull Request resolved: facebook/mysql-5.6#1267 Reviewed By: lth Differential Revision: D42928109 Pulled By: hermanlee fbshipit-source-id: 662dc11e7c9a8f8c0758006e20ccc739ebe09f40
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
May 27, 2024
Upstream commit ID: facebook/mysql-5.6@8fae2bb PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: In `rdb_i_s_sst_props_fields_info` definition, flag `MY_I_S_MAYBE_NULL` is missing for fields `COMPRESSION_ALGO`, `FILTER_POLICY`, `COMPRESSION_OPTIONS`, causing the `set_null` does not take effect, these 3 fields will keep last SST's value. This PR fixed this issue. Pull Request resolved: facebook/mysql-5.6#1267 Reviewed By: lth Differential Revision: D42928109 Pulled By: hermanlee fbshipit-source-id: 662dc11e7c9a8f8c0758006e20ccc739ebe09f40
VarunNagaraju
pushed a commit
to VarunNagaraju/percona-server
that referenced
this pull request
May 31, 2024
Upstream commit ID: facebook/mysql-5.6@8fae2bb PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: In `rdb_i_s_sst_props_fields_info` definition, flag `MY_I_S_MAYBE_NULL` is missing for fields `COMPRESSION_ALGO`, `FILTER_POLICY`, `COMPRESSION_OPTIONS`, causing the `set_null` does not take effect, these 3 fields will keep last SST's value. This PR fixed this issue. Pull Request resolved: facebook/mysql-5.6#1267 Reviewed By: lth Differential Revision: D42928109 Pulled By: hermanlee fbshipit-source-id: 662dc11e7c9a8f8c0758006e20ccc739ebe09f40
VarunNagaraju
pushed a commit
to VarunNagaraju/percona-server
that referenced
this pull request
Jun 5, 2024
Upstream commit ID: facebook/mysql-5.6@8fae2bb PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: In `rdb_i_s_sst_props_fields_info` definition, flag `MY_I_S_MAYBE_NULL` is missing for fields `COMPRESSION_ALGO`, `FILTER_POLICY`, `COMPRESSION_OPTIONS`, causing the `set_null` does not take effect, these 3 fields will keep last SST's value. This PR fixed this issue. Pull Request resolved: facebook/mysql-5.6#1267 Reviewed By: lth Differential Revision: D42928109 Pulled By: hermanlee fbshipit-source-id: 662dc11e7c9a8f8c0758006e20ccc739ebe09f40
VarunNagaraju
pushed a commit
to VarunNagaraju/percona-server
that referenced
this pull request
Jun 10, 2024
Upstream commit ID: facebook/mysql-5.6@8fae2bb PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: In `rdb_i_s_sst_props_fields_info` definition, flag `MY_I_S_MAYBE_NULL` is missing for fields `COMPRESSION_ALGO`, `FILTER_POLICY`, `COMPRESSION_OPTIONS`, causing the `set_null` does not take effect, these 3 fields will keep last SST's value. This PR fixed this issue. Pull Request resolved: facebook/mysql-5.6#1267 Reviewed By: lth Differential Revision: D42928109 Pulled By: hermanlee fbshipit-source-id: 662dc11e7c9a8f8c0758006e20ccc739ebe09f40
VarunNagaraju
pushed a commit
to VarunNagaraju/percona-server
that referenced
this pull request
Jun 12, 2024
Upstream commit ID: facebook/mysql-5.6@8fae2bb PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: In `rdb_i_s_sst_props_fields_info` definition, flag `MY_I_S_MAYBE_NULL` is missing for fields `COMPRESSION_ALGO`, `FILTER_POLICY`, `COMPRESSION_OPTIONS`, causing the `set_null` does not take effect, these 3 fields will keep last SST's value. This PR fixed this issue. Pull Request resolved: facebook/mysql-5.6#1267 Reviewed By: lth Differential Revision: D42928109 Pulled By: hermanlee fbshipit-source-id: 662dc11e7c9a8f8c0758006e20ccc739ebe09f40
VarunNagaraju
pushed a commit
to VarunNagaraju/percona-server
that referenced
this pull request
Jun 12, 2024
Upstream commit ID: facebook/mysql-5.6@8fae2bb PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: In `rdb_i_s_sst_props_fields_info` definition, flag `MY_I_S_MAYBE_NULL` is missing for fields `COMPRESSION_ALGO`, `FILTER_POLICY`, `COMPRESSION_OPTIONS`, causing the `set_null` does not take effect, these 3 fields will keep last SST's value. This PR fixed this issue. Pull Request resolved: facebook/mysql-5.6#1267 Reviewed By: lth Differential Revision: D42928109 Pulled By: hermanlee fbshipit-source-id: 662dc11e7c9a8f8c0758006e20ccc739ebe09f40
dlenev
pushed a commit
to dlenev/percona-server
that referenced
this pull request
Jul 25, 2024
Upstream commit ID: facebook/mysql-5.6@8fae2bb PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: In `rdb_i_s_sst_props_fields_info` definition, flag `MY_I_S_MAYBE_NULL` is missing for fields `COMPRESSION_ALGO`, `FILTER_POLICY`, `COMPRESSION_OPTIONS`, causing the `set_null` does not take effect, these 3 fields will keep last SST's value. This PR fixed this issue. Pull Request resolved: facebook/mysql-5.6#1267 Reviewed By: lth Differential Revision: D42928109 Pulled By: hermanlee fbshipit-source-id: 662dc11e7c9a8f8c0758006e20ccc739ebe09f40
dlenev
pushed a commit
to dlenev/percona-server
that referenced
this pull request
Jul 30, 2024
Upstream commit ID: facebook/mysql-5.6@8fae2bb PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: In `rdb_i_s_sst_props_fields_info` definition, flag `MY_I_S_MAYBE_NULL` is missing for fields `COMPRESSION_ALGO`, `FILTER_POLICY`, `COMPRESSION_OPTIONS`, causing the `set_null` does not take effect, these 3 fields will keep last SST's value. This PR fixed this issue. Pull Request resolved: facebook/mysql-5.6#1267 Reviewed By: lth Differential Revision: D42928109 Pulled By: hermanlee fbshipit-source-id: 662dc11e7c9a8f8c0758006e20ccc739ebe09f40
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 2, 2024
Summary: In `rdb_i_s_sst_props_fields_info` definition, flag `MY_I_S_MAYBE_NULL` is missing for fields `COMPRESSION_ALGO`, `FILTER_POLICY`, `COMPRESSION_OPTIONS`, causing the `set_null` does not take effect, these 3 fields will keep last SST's value. This PR fixed this issue. Pull Request resolved: facebook#1267 Reviewed By: lth Differential Revision: D42928109 Pulled By: hermanlee
dlenev
pushed a commit
to dlenev/percona-server
that referenced
this pull request
Aug 21, 2024
Upstream commit ID: facebook/mysql-5.6@8fae2bb PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: In `rdb_i_s_sst_props_fields_info` definition, flag `MY_I_S_MAYBE_NULL` is missing for fields `COMPRESSION_ALGO`, `FILTER_POLICY`, `COMPRESSION_OPTIONS`, causing the `set_null` does not take effect, these 3 fields will keep last SST's value. This PR fixed this issue. Pull Request resolved: facebook/mysql-5.6#1267 Reviewed By: lth Differential Revision: D42928109 Pulled By: hermanlee fbshipit-source-id: 662dc11e7c9a8f8c0758006e20ccc739ebe09f40
dlenev
pushed a commit
to dlenev/percona-server
that referenced
this pull request
Aug 28, 2024
Upstream commit ID: facebook/mysql-5.6@8fae2bb PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: In `rdb_i_s_sst_props_fields_info` definition, flag `MY_I_S_MAYBE_NULL` is missing for fields `COMPRESSION_ALGO`, `FILTER_POLICY`, `COMPRESSION_OPTIONS`, causing the `set_null` does not take effect, these 3 fields will keep last SST's value. This PR fixed this issue. Pull Request resolved: facebook/mysql-5.6#1267 Reviewed By: lth Differential Revision: D42928109 Pulled By: hermanlee fbshipit-source-id: 662dc11e7c9a8f8c0758006e20ccc739ebe09f40
dlenev
pushed a commit
to dlenev/percona-server
that referenced
this pull request
Aug 30, 2024
Upstream commit ID: facebook/mysql-5.6@8fae2bb PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: In `rdb_i_s_sst_props_fields_info` definition, flag `MY_I_S_MAYBE_NULL` is missing for fields `COMPRESSION_ALGO`, `FILTER_POLICY`, `COMPRESSION_OPTIONS`, causing the `set_null` does not take effect, these 3 fields will keep last SST's value. This PR fixed this issue. Pull Request resolved: facebook/mysql-5.6#1267 Reviewed By: lth Differential Revision: D42928109 Pulled By: hermanlee fbshipit-source-id: 662dc11e7c9a8f8c0758006e20ccc739ebe09f40
inikep
pushed a commit
to percona/percona-server
that referenced
this pull request
Sep 23, 2024
Upstream commit ID: facebook/mysql-5.6@8fae2bb PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: In `rdb_i_s_sst_props_fields_info` definition, flag `MY_I_S_MAYBE_NULL` is missing for fields `COMPRESSION_ALGO`, `FILTER_POLICY`, `COMPRESSION_OPTIONS`, causing the `set_null` does not take effect, these 3 fields will keep last SST's value. This PR fixed this issue. Pull Request resolved: facebook/mysql-5.6#1267 Reviewed By: lth Differential Revision: D42928109 Pulled By: hermanlee fbshipit-source-id: 662dc11e7c9a8f8c0758006e20ccc739ebe09f40
inikep
pushed a commit
to percona/percona-server
that referenced
this pull request
Sep 25, 2024
Upstream commit ID: facebook/mysql-5.6@8fae2bb PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: In `rdb_i_s_sst_props_fields_info` definition, flag `MY_I_S_MAYBE_NULL` is missing for fields `COMPRESSION_ALGO`, `FILTER_POLICY`, `COMPRESSION_OPTIONS`, causing the `set_null` does not take effect, these 3 fields will keep last SST's value. This PR fixed this issue. Pull Request resolved: facebook/mysql-5.6#1267 Reviewed By: lth Differential Revision: D42928109 Pulled By: hermanlee fbshipit-source-id: 662dc11e7c9a8f8c0758006e20ccc739ebe09f40
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Sep 25, 2024
Upstream commit ID: facebook/mysql-5.6@8fae2bb PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: In `rdb_i_s_sst_props_fields_info` definition, flag `MY_I_S_MAYBE_NULL` is missing for fields `COMPRESSION_ALGO`, `FILTER_POLICY`, `COMPRESSION_OPTIONS`, causing the `set_null` does not take effect, these 3 fields will keep last SST's value. This PR fixed this issue. Pull Request resolved: facebook/mysql-5.6#1267 Reviewed By: lth Differential Revision: D42928109 Pulled By: hermanlee fbshipit-source-id: 662dc11e7c9a8f8c0758006e20ccc739ebe09f40
dlenev
pushed a commit
to dlenev/percona-server
that referenced
this pull request
Oct 17, 2024
Upstream commit ID: facebook/mysql-5.6@8fae2bb PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: In `rdb_i_s_sst_props_fields_info` definition, flag `MY_I_S_MAYBE_NULL` is missing for fields `COMPRESSION_ALGO`, `FILTER_POLICY`, `COMPRESSION_OPTIONS`, causing the `set_null` does not take effect, these 3 fields will keep last SST's value. This PR fixed this issue. Pull Request resolved: facebook/mysql-5.6#1267 Reviewed By: lth Differential Revision: D42928109 Pulled By: hermanlee fbshipit-source-id: 662dc11e7c9a8f8c0758006e20ccc739ebe09f40
dlenev
pushed a commit
to dlenev/percona-server
that referenced
this pull request
Oct 17, 2024
Upstream commit ID: facebook/mysql-5.6@8fae2bb PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: In `rdb_i_s_sst_props_fields_info` definition, flag `MY_I_S_MAYBE_NULL` is missing for fields `COMPRESSION_ALGO`, `FILTER_POLICY`, `COMPRESSION_OPTIONS`, causing the `set_null` does not take effect, these 3 fields will keep last SST's value. This PR fixed this issue. Pull Request resolved: facebook/mysql-5.6#1267 Reviewed By: lth Differential Revision: D42928109 Pulled By: hermanlee fbshipit-source-id: 662dc11e7c9a8f8c0758006e20ccc739ebe09f40
dlenev
pushed a commit
to dlenev/percona-server
that referenced
this pull request
Oct 22, 2024
Upstream commit ID: facebook/mysql-5.6@8fae2bb PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: In `rdb_i_s_sst_props_fields_info` definition, flag `MY_I_S_MAYBE_NULL` is missing for fields `COMPRESSION_ALGO`, `FILTER_POLICY`, `COMPRESSION_OPTIONS`, causing the `set_null` does not take effect, these 3 fields will keep last SST's value. This PR fixed this issue. Pull Request resolved: facebook/mysql-5.6#1267 Reviewed By: lth Differential Revision: D42928109 Pulled By: hermanlee fbshipit-source-id: 662dc11e7c9a8f8c0758006e20ccc739ebe09f40
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Oct 28, 2024
Upstream commit ID: facebook/mysql-5.6@8fae2bb PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: In `rdb_i_s_sst_props_fields_info` definition, flag `MY_I_S_MAYBE_NULL` is missing for fields `COMPRESSION_ALGO`, `FILTER_POLICY`, `COMPRESSION_OPTIONS`, causing the `set_null` does not take effect, these 3 fields will keep last SST's value. This PR fixed this issue. Pull Request resolved: facebook/mysql-5.6#1267 Reviewed By: lth Differential Revision: D42928109 Pulled By: hermanlee fbshipit-source-id: 662dc11e7c9a8f8c0758006e20ccc739ebe09f40
inikep
pushed a commit
to percona/percona-server
that referenced
this pull request
Oct 30, 2024
Upstream commit ID: facebook/mysql-5.6@8fae2bb PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: In `rdb_i_s_sst_props_fields_info` definition, flag `MY_I_S_MAYBE_NULL` is missing for fields `COMPRESSION_ALGO`, `FILTER_POLICY`, `COMPRESSION_OPTIONS`, causing the `set_null` does not take effect, these 3 fields will keep last SST's value. This PR fixed this issue. Pull Request resolved: facebook/mysql-5.6#1267 Reviewed By: lth Differential Revision: D42928109 Pulled By: hermanlee fbshipit-source-id: 662dc11e7c9a8f8c0758006e20ccc739ebe09f40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
rdb_i_s_sst_props_fields_info
definition, flagMY_I_S_MAYBE_NULL
is missing for fieldsCOMPRESSION_ALGO
,FILTER_POLICY
,COMPRESSION_OPTIONS
, causing theset_null
does not take effect, these 3 fields will keep last SST's value.This PR fixed this issue.