Add ddst_dict_init api support for rocksdb dd #1297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunshine-Chun
force-pushed
the
fb-mysql-8.0.28-dd-api2
branch
from
66fa355
to
4fddbc6
Compare
storage/rocksdb/ha_rocksdb.cc
Outdated
|
|
||
| static Plugin_tablespace dd_space(rocksdb_dd_space_name, "", "", "", | ||
| rocksdb_hton_name); | ||
| tablespaces->push_back(&dd_space); |
There was a problem hiding this comment.
On a second thought, tablespaces are purely InnoDB concept. So nothing should be added here?
There was a problem hiding this comment.
I think DD expect mysql namespace always exists.. Let me find related code in a while..
There was a problem hiding this comment.
The current DD layer assumes it does, but I am patching it out in my prototype.
I am concerned about pretending something exists when MyRocks does not even support the concept of it.
sunshine-Chun
force-pushed
the
fb-mysql-8.0.28-dd-api2
branch
2 times, most recently
from
88b36f4
to
7897e70
Compare
storage/rocksdb/rdb_native_dd.h
Outdated
|
|
||
| namespace dd { | ||
| class Table; | ||
| } | ||
|
|
||
| namespace myrocks { | ||
|
|
||
| constexpr const char *rocksdb_dd_space_name = "mysql"; |
There was a problem hiding this comment.
Suggested change
| constexpr const char *rocksdb_dd_space_name = "mysql"; | |
| constexpr const char rocksdb_dd_space_name[] = "mysql"; |
The pointer version works, but its sizeof is 8, which is very annoying to find
|
Do we still need this diff. Sounds like we are not adding the. dd_space in the ddst_dict_init function now. |
|
As with the rest of the current diffs, it's hard to say, as the code is too incomplete to run. IMHO we can hold until it becomes clear. |
|
@sunshine-Chun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@laurynas-biveinis , according to previous conversation, we may still need this mysql tablespace. Currently #1319 will fail if there is testcase using rocksdb DD. |
sunshine-Chun
force-pushed
the
fb-mysql-8.0.28-dd-api2
branch
from
7897e70
to
8dcbca4
Compare
|
@sunshine-Chun has updated the pull request. You must reimport the pull request before landing. |
|
@sunshine-Chun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
sunshine-Chun
force-pushed
the
fb-mysql-8.0.28-dd-api2
branch
from
8dcbca4
to
4d98701
Compare
|
@sunshine-Chun has updated the pull request. You must reimport the pull request before landing. |
sunshine-Chun
force-pushed
the
fb-mysql-8.0.28-dd-api2
branch
from
4d98701
to
0593d65
Compare
|
@sunshine-Chun has updated the pull request. You must reimport the pull request before landing. |
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
sunshine-Chun
force-pushed
the
fb-mysql-8.0.28-dd-api2
branch
from
0593d65
to
0f1e9a8
Compare
|
@sunshine-Chun has updated the pull request. You must reimport the pull request before landing. |
|
@sunshine-Chun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@sunshine-Chun , @luqun, It is true that we'll need the mysql tablespace. But, in the current prototype it is InnoDB that sets it up, thus at this point I am not comfortable to committing to RocksDB creating it. We could quickly merge a PR for |
luqun
pushed a commit
to luqun/mysql-5.6
that referenced
this pull request
Jun 20, 2023
Summary: Add ddst_dict_init handler api support for rocksdb dd Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize. Pull Request resolved: facebook#1297 GitHub Author: Chun Ni <chni@fb.com> Test Plan: CI Reviewers: luqun Subscribers: webscalesql-eng@fb.com Differential Revision: https://phabricator.intern.facebook.com/D46700996 Tags: accept2ship
hermanlee
pushed a commit
to hermanlee/mysql-5.6
that referenced
this pull request
Oct 3, 2023
Summary: Add ddst_dict_init handler api support for rocksdb dd Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize. Pull Request resolved: facebook#1297 Test Plan: CI Differential Revision: D46700996
hermanlee
pushed a commit
to hermanlee/mysql-5.6
that referenced
this pull request
Oct 18, 2023
Summary: Add ddst_dict_init handler api support for rocksdb dd Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize. Pull Request resolved: facebook#1297 Test Plan: CI Differential Revision: D46700996
|
@sunshine-Chun , please close this PR |
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Dec 20, 2023
Summary: Add ddst_dict_init handler api support for rocksdb dd Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize. Pull Request resolved: facebook/mysql-5.6#1297 Test Plan: CI Differential Revision: D46700996 fbshipit-source-id: fbb80035b54cc068c845e63fe6903c8488fce1d3
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Dec 20, 2023
Summary: Add ddst_dict_init handler api support for rocksdb dd Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize. Pull Request resolved: facebook/mysql-5.6#1297 Test Plan: CI Differential Revision: D46700996 fbshipit-source-id: fbb80035b54cc068c845e63fe6903c8488fce1d3
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 7, 2024
Summary: Add ddst_dict_init handler api support for rocksdb dd Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize. Pull Request resolved: facebook#1297 Test Plan: CI Differential Revision: D46700996
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 8, 2024
Summary: Add ddst_dict_init handler api support for rocksdb dd Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize. Pull Request resolved: facebook#1297 Test Plan: CI Differential Revision: D46700996
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 9, 2024
Summary: Add ddst_dict_init handler api support for rocksdb dd Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize. Pull Request resolved: facebook#1297 Test Plan: CI Differential Revision: D46700996
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 10, 2024
Summary: Add ddst_dict_init handler api support for rocksdb dd Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize. Pull Request resolved: facebook#1297 Test Plan: CI Differential Revision: D46700996
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 13, 2024
Summary: Add ddst_dict_init handler api support for rocksdb dd Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize. Pull Request resolved: facebook#1297 Test Plan: CI Differential Revision: D46700996
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 15, 2024
Summary: Add ddst_dict_init handler api support for rocksdb dd Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize. Pull Request resolved: facebook#1297 Test Plan: CI Differential Revision: D46700996
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 16, 2024
Summary: Add ddst_dict_init handler api support for rocksdb dd Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize. Pull Request resolved: facebook#1297 Test Plan: CI Differential Revision: D46700996
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 17, 2024
Summary: Add ddst_dict_init handler api support for rocksdb dd Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize. Pull Request resolved: facebook#1297 Test Plan: CI Differential Revision: D46700996
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 17, 2024
Summary: Add ddst_dict_init handler api support for rocksdb dd Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize. Pull Request resolved: facebook#1297 Test Plan: CI Differential Revision: D46700996
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 21, 2024
Summary: Add ddst_dict_init handler api support for rocksdb dd Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize. Pull Request resolved: facebook#1297 Test Plan: CI Differential Revision: D46700996
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 21, 2024
Summary: Add ddst_dict_init handler api support for rocksdb dd Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize. Pull Request resolved: facebook#1297 Test Plan: CI Differential Revision: D46700996
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 30, 2024
Summary: Add ddst_dict_init handler api support for rocksdb dd Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize. Pull Request resolved: facebook#1297 Test Plan: CI Differential Revision: D46700996
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 16, 2024
Summary: Add ddst_dict_init handler api support for rocksdb dd Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize. Pull Request resolved: facebook#1297 Test Plan: CI Differential Revision: D46700996
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 16, 2024
Summary: Add ddst_dict_init handler api support for rocksdb dd Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize. Pull Request resolved: facebook#1297 Test Plan: CI Differential Revision: D46700996
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 17, 2024
Summary: Add ddst_dict_init handler api support for rocksdb dd Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize. Pull Request resolved: facebook#1297 Test Plan: CI Differential Revision: D46700996
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 19, 2024
Summary: Add ddst_dict_init handler api support for rocksdb dd Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize. Pull Request resolved: facebook#1297 Test Plan: CI Differential Revision: D46700996
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 19, 2024
Summary: Add ddst_dict_init handler api support for rocksdb dd Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize. Pull Request resolved: facebook#1297 Test Plan: CI Differential Revision: D46700996
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 30, 2024
Summary: Add ddst_dict_init handler api support for rocksdb dd Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize. Pull Request resolved: facebook#1297 Test Plan: CI Differential Revision: D46700996
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 31, 2024
Summary: Add ddst_dict_init handler api support for rocksdb dd Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize. Pull Request resolved: facebook#1297 Test Plan: CI Differential Revision: D46700996
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 2, 2024
Summary: Add ddst_dict_init handler api support for rocksdb dd Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize. Pull Request resolved: facebook#1297 Test Plan: CI Differential Revision: D46700996
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 6, 2024
Summary: Add ddst_dict_init handler api support for rocksdb dd Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize. Pull Request resolved: facebook#1297 Test Plan: CI Differential Revision: D46700996
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Add ddst_dict_init api support for rocksdb dd
Test Plan: Test locally, not crush....
Reviewers:
Subscribers:
Tasks:
Tags: