Myrocks range locking #1449
Draft
Myrocks range locking #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a draft pull request: prerequisite branches not removed, there are test failures, including crashes, and not all the review comments have been addressed yet. But it should be possible to continue reviewing code |
laurynas-biveinis
force-pushed
the
myr-range-locking
branch
from
6f3cc1f
to
1af3e9f
Compare
- Add new sysvar, rocksdb_use_range_locking. When it's on: - RocksDB is initialized to used range-locking lock manager - For all DML operations (including SELECT ... FOR UPDATE), the scanned range will be locked before reading/modifying rows - For all DML operations, MyRocks will read and modify the latest committed data, just like InnoDB does, because there is no snapshot checking if range locking is used. - Introduce a RocksDB locking iterator, which reads the rows, locks the range, - and re-reads the rows. It is used for queries that do not have a finite range to scan, like UPDATE t1 ... ORDER BY t1.key LIMIT n - Add another new sysvar, rocksdb_use_range_lock_manager_as_point, which uses the point locking algorithm but the lock manager used is the range one. - Add enabled rocksdb_use_range_locking as another MTR rocksdb suite test combination. Co-authored-by: Sergei Petrunia <sergey@mariadb.com> Co-authored-by: Laurynas Biveinis <laurynas.biveinis@gmail.com>
laurynas-biveinis
force-pushed
the
myr-range-locking
branch
from
1927fc6
to
3b35dab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.