Use python3 from $PATH instead of absolute paths #1466
Conversation
|
@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
after change from /usr/bin/python3 to pythohn3, some of MTR failed to find due to "ModuleNotFoundError: No module named 'MySQLdb'". |
|
Do you know what python3 are the scripts picking up? Is it possible to adjust PATH to put /usr/bin before that? |
the pyhon3 in /usr/local/sbin instead of /usr/bin/python3.. need to do some investigation since this PATH variable comes from SYSTEM. |
|
Ack, let me know. I believe the right thing is for the script to run in
a correctly-set up environment instead of hardcoding paths, but let me
know if that's impossible for some reason
luqun ***@***.***> writes:
… Do you know what python3 are the scripts picking up? Is it possible to adjust PATH to put /usr/bin before that?
the pyhon3 in /usr/local/sbin instead of /usr/bin/python3.. need to do some investigation since this PATH variable comes from
SYSTEM.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.
|
|
As discussed offline, will conditionalize on the OS |
|
@luqun , @hermanlee , could you tell which tests break with this PR in its current form? I am wondering if I could leave script shebangs using env |
such as main.admission_control_multi_query_wait_events |
|
@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This allows using Python virtualenv directly. This partially reverts changes in 9d0dda0, but its commit message is not stating anything about absolute paths. For some tests, do this conditionally based on the platform due to some test hosts requiring the hardcoded paths.
laurynas-biveinis
force-pushed
the
stress-test-fixes
branch
from
fa795df
to
a57e4a2
Compare
|
@laurynas-biveinis has updated the pull request. You must reimport the pull request before landing. |
I have updated the three tests in the main suite to choose $PATH or hardcoded python conditionally. Let me know if any other tests need updating |
|
@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This allows using Python virtualenv directly. This partially reverts changes in
9d0dda0, but its commit message is not stating
anything about absolute paths.