This repository has been archived by the owner on Sep 1, 2024. It is now read-only.
Temporarily revert "Add exact type checker from react native" #80
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #41
cc @aweary
There were two issues that were missed during review:
Prod version
See this comment. Lists in these two files must be in sync. This is essential because as far as I can see
PropTypes.exact({}).isRequired
will throw in production code.We need to automate this check because I agree it's not obvious.
Object.assign
I don't think this repo is set up to polyfill Object.assign yet, so this will throw in older browsers.
Way forward
@aweary Can you fix those two issues? Happy to take the PR back in after that.
For now I have to revert because I don't have time to fix forward and I'm worried we'll forget about this, and ship a broken version.