Update flow control settings names to reflect that these are indeed flow

Summary: Update flow control settings names to reflect that these are indeed flow control Reviewed By: jbeshay Differential Revision: D48137685 fbshipit-source-id: a48372e21cdd529480e25785a9bd5de456427ef3
facebook · Aug 18, 2023 · db6d58c · db6d58c
1 parent f1a0712
commit db6d58c
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 11 deletions.
diff --git a/proxygen/httpclient/samples/httperf2/Client.cpp b/proxygen/httpclient/samples/httperf2/Client.cpp
@@ -189,16 +189,16 @@ static quic::TransportSettings createTransportSettings() {
   transportSettings.maxRecvPacketSize = FLAGS_max_receive_packet_size;
   transportSettings.canIgnorePathMTU = FLAGS_can_ignore_pmtu;
   if (FLAGS_conn_flow_control != 0) {
-    transportSettings.advertisedInitialConnectionWindowSize =
+    transportSettings.advertisedInitialConnectionFlowControlWindow =
         FLAGS_conn_flow_control;
   }
   // TODO FLAGS_stream_*
   if (FLAGS_stream_flow_control != 0) {
-    transportSettings.advertisedInitialBidiLocalStreamWindowSize =
+    transportSettings.advertisedInitialBidiLocalStreamFlowControlWindow =
         FLAGS_stream_flow_control;
-    transportSettings.advertisedInitialBidiRemoteStreamWindowSize =
+    transportSettings.advertisedInitialBidiRemoteStreamFlowControlWindow =
         FLAGS_stream_flow_control;
-    transportSettings.advertisedInitialUniStreamWindowSize =
+    transportSettings.advertisedInitialUniStreamFlowControlWindow =
         FLAGS_stream_flow_control;
   }
 

diff --git a/proxygen/httpserver/samples/hq/H2Server.cpp b/proxygen/httpserver/samples/hq/H2Server.cpp
@@ -44,11 +44,13 @@ std::unique_ptr<proxygen::HTTPServerOptions> H2Server::createServerOptions(
   serverOptions->enableContentCompression =
       params.httpServerEnableContentCompression;
   serverOptions->initialReceiveWindow =
-      params.transportSettings.advertisedInitialBidiLocalStreamWindowSize;
+      params.transportSettings
+          .advertisedInitialBidiLocalStreamFlowControlWindow;
   serverOptions->receiveStreamWindowSize =
-      params.transportSettings.advertisedInitialBidiLocalStreamWindowSize;
+      params.transportSettings
+          .advertisedInitialBidiLocalStreamFlowControlWindow;
   serverOptions->receiveSessionWindowSize =
-      params.transportSettings.advertisedInitialConnectionWindowSize;
+      params.transportSettings.advertisedInitialConnectionFlowControlWindow;
   serverOptions->handlerFactories =
       proxygen::RequestHandlerChain()
           .addThen<SampleHandlerFactory>(

diff --git a/proxygen/httpserver/samples/hq/HQCommandLine.cpp b/proxygen/httpserver/samples/hq/HQCommandLine.cpp
@@ -211,13 +211,14 @@ void initializeTransportSettings(HQToolParams& hqUberParams) {
                                proxygen::kHQCurrentDraft};
   }
 
-  hqParams.transportSettings.advertisedInitialConnectionWindowSize =
+  hqParams.transportSettings.advertisedInitialConnectionFlowControlWindow =
       FLAGS_conn_flow_control;
-  hqParams.transportSettings.advertisedInitialBidiLocalStreamWindowSize =
+  hqParams.transportSettings.advertisedInitialBidiLocalStreamFlowControlWindow =
       FLAGS_stream_flow_control;
-  hqParams.transportSettings.advertisedInitialBidiRemoteStreamWindowSize =
+  hqParams.transportSettings
+      .advertisedInitialBidiRemoteStreamFlowControlWindow =
       FLAGS_stream_flow_control;
-  hqParams.transportSettings.advertisedInitialUniStreamWindowSize =
+  hqParams.transportSettings.advertisedInitialUniStreamFlowControlWindow =
       FLAGS_stream_flow_control;
   hqParams.congestionControlName = FLAGS_congestion;
   hqParams.congestionControl =