This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Fix false positive feature-detection check #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous attribute, 'actualDuration', was present in 16.4 releases of React as well– even though profiler has changed a bit since that release. The new attribute will only exist in the upcoming release.
|
Merging without a review because this change is tiny and uncontroversial. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the issue brought up with this comment by improving our feature-detection check to avoid false positive from 16.4
The
actualDurationfield was added by facebook/react/pull/12910 and was released in 16.4.The☹️
treeBaseDurationfield was renamed with facebook/react/pull/13156 in order to allow us to distinguish between the initial profiling release and a more stable one. I intended to switch DevTools to use this field but apparently forgot to.