This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Set readable names for date objects. #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you look at #388, you will see that there is a discussion with another person working on it, and a label saying "someone is working on this". I appreciate the pull request, but I will close this without reviewing because we need to give the person who already started the work a chance to finish it. If he gets stuck, and we can't work it out, or loses interest, I'll remove the "someone is working on this" label, and the task will be up for grabs again. Thanks! |
|
Reopening since #559 received no followup. |
gaearon
reviewed
Apr 20, 2017
agent/dehydrate.js
Outdated
| @@ -77,8 +77,10 @@ function dehydrate(data: Object, cleaned: Array<Array<string>>, path?: Array<str | |||
| // TODO when this is in the iframe window, we can just use Object | |||
| if (data.constructor && typeof data.constructor === 'function' && data.constructor.name !== 'Object') { | |||
| cleaned.push(path); | |||
| const isDate = data.constructor.name === 'Date'; | |||
There was a problem hiding this comment.
Is this check guaranteed to work? Maybe we can do something safer, like Object.prototype.toString.call(data)?
zinoviev
force-pushed
the
display_date_values
branch
from
e616541
to
936afea
Compare
|
@gaearon rebased and updated |
For consistency with how Chrome displays it (it's an object after all)
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #388