This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
[React Native] Fix instance measure of rnstyle for Android #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doesn't this mean React Native itself has a bug in |
It should be a bug in React Native, it seems this issue is only for some top-level
The built-in inspector doesn't throw any errors, so I think we can avoid the error first in here. I might to tracking code of React Native for Android, try to fix it or just file an issue. |
|
Thanks. I’ll merge this for now but please raise an issue in RN. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like measure some instance will got
undefinedin Android (See this comment), we can avoid it useundefinedvalues asmeasuredLayoutsend to react-devtools.The original errors will causing react-devtools not to work properly on Android.