Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Accessibility Documentation #2679

Closed
AgneLukoseviciute opened this issue Jul 6, 2021 · 4 comments · Fixed by #2692
Closed

Update Accessibility Documentation #2679

AgneLukoseviciute opened this issue Jul 6, 2021 · 4 comments · Fixed by #2692
Labels
👋 Good first issue Interested in collaborating? Take a stab at fixing one of these issues. p: microsoft Partner

Comments

@AgneLukoseviciute
Copy link

RN #31532 added accessibility actions to Button, TextInput, Text, and Picker. Documentation should be updated to include AccessibilityActions and onAccessibilityAction props for those components.

Namely, Text and Button have no mention of these props.

@Simek
Copy link
Collaborator

Simek commented Jul 6, 2021

Hi @AgneLukoseviciute, thank you for creating an issue. However it looks like the commit is only a part of master branch and won't be avaible in 0.65 release (unless the commit will be cherry-picked). To avoid confusing people those props should be added to next branch after the 0.65 documentation will be cut.

CC @lunaleaps @kacieb

@lunaleaps
Copy link
Contributor

lunaleaps commented Jul 7, 2021

I think this would be a great first issue! Added the tag!

@lunaleaps lunaleaps added the 👋 Good first issue Interested in collaborating? Take a stab at fixing one of these issues. label Jul 7, 2021
@EvanErickson
Copy link

Can someone elaborate on what exactly is needed? I'm happy to do a PR for this but I've never used it before.

@lunaleaps
Copy link
Contributor

@EvanErickson If you check out the RN docs right now we have documentation on accessibility actions: https://reactnative.dev/docs/next/accessibility#accessibility-actions
and specifically we have documentation on the relevant props on the View component: https://reactnative.dev/docs/next/view#accessibilityactions

What @AgneLukoseviciute mentioned is that we recently added support for the relevant accessibilityAction props to a few more components like Button, TextInput, and Text so we'd want to update the docs for those components to include the relevant props (onAccessibilityAction, accessibilityActions.. I believe it's just those two) for those components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👋 Good first issue Interested in collaborating? Take a stab at fixing one of these issues. p: microsoft Partner
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants