-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds accessiblity actions on core components #31532
Adds accessiblity actions on core components #31532
Conversation
Hi @dennisurtubia! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Base commit: b2ec89f |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Base commit: b2ec89f |
@dennisurtubia Thanks for this PR! Can we also add the examples you're using to test Button and Picker? Also, are you able to test on iOS as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How are the props passed to Picker.ios.js? Were you able to test on this platform? If not, I can help test it out. In addition, would be helpful to add your test cases to RNTester
@@ -115,6 +120,10 @@ type PickerProps = $ReadOnly<{| | |||
* The string used for the accessibility label. Will be read once focused on the picker but not on change. | |||
*/ | |||
accessibilityLabel?: ?string, | |||
|
|||
accessible?: ?boolean, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add a comment for each prop as well as the other props do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I will improve this!
Hey, @lunaleaps, unfortunately I can't test on iOS. On the issue, it is only mentioned that the Android platform has implemented the properties Of course! I will add the tests to the RNTester. Thank you for your suggestions! |
26a708b
to
e7d1287
Compare
Hello, @lunaleaps! I checked how the props are passed to Picker.ios.js, and on the file, we can see that all props from ViewProps are passed, and, ViewProps have all required props ( |
@lunaleaps has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dennisurtubia! Have imported it and tested on iOS and Android! I can take a look into why TextInput is failing
Nice! I can resolve the conflict found in the |
@lunaleaps merged this pull request in 4471715. |
Thank you @dennisurtubia for your contribution to a more accessible React Native! I'd like to highlight your contribution on Twitter, do you have a Twitter handle I can tag? |
Yes! @dennisurtubia my username. Thanks! |
Summary
Android: Adding custom actions (#30854).
Adds accessiblity actions on core components (Button, TextInput, Text, and Picker).
Changelog
[General] [Added] - Adds accessiblity actions on core components
Test Plan
npm test
RNTesterApp
using talkback:activate
action for all components;Notes
TextInput
an unexpected error is raised: