Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for https://github.com/facebook/react-native/pull/17747 #156

Closed
wants to merge 1 commit into from

Conversation

msand
Copy link

@msand msand commented Jan 26, 2018

Update docs for facebook/react-native#17747

@react-native-bot
Copy link

Deploy preview for react-native ready!

Built with commit bba7a94

https://deploy-preview-156--react-native.netlify.com

@hramos
Copy link
Contributor

hramos commented Jan 26, 2018

Thanks, let's come back to this when the PR is merged.

@charpeni charpeni added the 🕐 Waiting on PR These may be waiting for a PR to the facebook/react-native to be merged label Jan 27, 2018
@hey99xx
Copy link

hey99xx commented Feb 8, 2018

Wait how does this commit makes sense without updating build.gradle of RN simultaneously?

This is changing

Android SDK version 23 27 (compileSdkVersion in build.gradle)

and

SDK build tools version ~23.0.1~~ 26.0.2 (buildToolsVersion in build.gradle)

But if you look at the relevant part of build.gradle the numbers there are still are

android {
    compileSdkVersion 23
    buildToolsVersion "23.0.1"

So I think merging this PR as it is will only create confusion, because the docs will suggest Android tools that have a mismatch with what RN actually uses.

Edit: The other PR at facebook/react-native@43fdacc#diff-22bd14e85636c66689f1a94a02a56b22R4 still has mismatch with this doc PR (26.0.2 vs 27.0.3).

@msand
Copy link
Author

msand commented Feb 8, 2018

@hey99xx I had updated and force-pushed to the branch in the PR in RN, and am waiting for more feedback facebook/react-native#17747 (comment)
Haven't updated this PR to reflect those changes in versions here yet.

@msand
Copy link
Author

msand commented Feb 8, 2018

But, the instructions about build tool versions could probably be removed completely, as the new gradle version will pick one itself depending on compatibility.

@cpojer
Copy link
Contributor

cpojer commented Feb 7, 2019

It seems like this is outdated now and we'll need a new PR with the latest versions for everything. Sorry that it took so long to get back to this.

@cpojer cpojer closed this Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕐 Waiting on PR These may be waiting for a PR to the facebook/react-native to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants