fix Environment Setup page sections, backport all the changes to 0.63 #2104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for react-native ready! Built with commit 768d0aa https://deploy-preview-2104--react-native.netlify.app Changes to Thank you for your contributions. |
rachelnabors
suggested changes
Jul 28, 2020
There was a problem hiding this comment.
Could I ask that we leave the content of the notes in? Like:
If you're familiar with web development, Metro is a lot like webpack—for React Native apps. Unlike Kotlin or Java, JavaScript isn't compiled—and neither is React Native. Bundling isn't the same as compiling, but it can help improve startup performance and translate some platform-specific JavaScript into more JavaScript.
|
Thanks for nabbing this one! Phew! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2019
This PR fixes the problem described in the issue above and fixes the issue with initial page render (unnecessary sections were visible before the user interacts with tabs).
@rachelnabors Unfortunately I was not able to fix the issue and retain the
devNoteblocks, so the fix requires to removed them. I will work on restoring them in the future. To make the fix available to most of the users I have also backported all the changes from the current page to0.63versioned docs.