Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Environment Setup page sections, backport all the changes to 0.63 #2104

Merged
merged 2 commits into from
Jul 29, 2020

Conversation

Simek
Copy link
Collaborator

@Simek Simek commented Jul 27, 2020

Fixes #2019

This PR fixes the problem described in the issue above and fixes the issue with initial page render (unnecessary sections were visible before the user interacts with tabs).

@rachelnabors Unfortunately I was not able to fix the issue and retain the devNote blocks, so the fix requires to removed them. I will work on restoring them in the future. To make the fix available to most of the users I have also backported all the changes from the current page to 0.63 versioned docs.

@Simek Simek requested a review from rachelnabors July 27, 2020 14:27
@react-native-bot
Copy link

react-native-bot commented Jul 27, 2020

Deploy preview for react-native ready!

Built with commit 768d0aa

https://deploy-preview-2104--react-native.netlify.app

Changes to docs/ are reflected in the next "master" version.

Thank you for your contributions.

How to ContributeDocumentation Sources

Copy link
Contributor

@rachelnabors rachelnabors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could I ask that we leave the content of the notes in? Like:

If you're familiar with web development, Metro is a lot like webpack—for React Native apps. Unlike Kotlin or Java, JavaScript isn't compiled—and neither is React Native. Bundling isn't the same as compiling, but it can help improve startup performance and translate some platform-specific JavaScript into more JavaScript.

@Simek Simek requested a review from rachelnabors July 28, 2020 22:49
@rachelnabors rachelnabors merged commit 7058cc7 into facebook:master Jul 29, 2020
@rachelnabors
Copy link
Contributor

Thanks for nabbing this one! Phew!

@Simek Simek linked an issue Jul 29, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested blocks are not correctly rendered
4 participants