Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

attempt to fix trailing slash issues on GH pages #2297

Merged
merged 2 commits into from
Oct 31, 2020
Merged

attempt to fix trailing slash issues on GH pages #2297

merged 2 commits into from
Oct 31, 2020

Conversation

slorber
Copy link
Contributor

@slorber slorber commented Oct 31, 2020 •
edited
Loading

cc @Simek , should fix Github Pages trailing slash issues

/myDoc will not redirect 301 to /myDoc/ anymore

Temporary fixes #2291

@netlify
Copy link

netlify bot commented Oct 31, 2020 •
edited
Loading

Deploy preview for react-native ready!

Built with commit 503f231

https://deploy-preview-2297--react-native.netlify.app

@slorber slorber mentioned this pull request Oct 31, 2020
Closed
Simek
Simek approved these changes Oct 31, 2020
View reviewed changes
Copy link
Collaborator

@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your work on the fix for those issues! 👍

@Simek Simek merged commit d32db6e into facebook:master Oct 31, 2020
@slorber slorber mentioned this pull request Jan 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Simek Simek Simek approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken links and trailing slash issues on the website
3 participants
@slorber @Simek @facebook-github-bot