Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added suggestion for maintainVisibleContentPosition support on android #2457

Conversation

vishalnarkhede
Copy link

ScrollView and FlatList supports a prop - maintainVisibleContentPosition, which is super useful in implementing bi-directional infinite scroll. Although it is only available for iOS right now. Until react-native team adds support for this prop on android, one could use alternative. - @stream-io/flat-list-mvcp.

#29055

@facebook-github-bot
Copy link

Hi @vishalnarkhede!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@vishalnarkhede vishalnarkhede changed the title Added alternative library for maintainVisibleContentPosition support on android Added suggestion for maintainVisibleContentPosition support on android Jan 24, 2021
@netlify
Copy link

netlify bot commented Jan 24, 2021

Deploy preview for react-native ready!

Built with commit 2bdc3c5

https://deploy-preview-2457--react-native.netlify.app

@vishalnarkhede
Copy link
Author

What do you think about this @Simek ? I am going to maintain this library till we have support for this prop OOTB from RN. Might as well recommend it to other users :)

@Simek
Copy link
Collaborator

Simek commented Feb 1, 2021

Hi @vishalnarkhede, we usually do not include/recommend the complementary, third-party libraries in the Components/APIs docs, rarely we include them in the guides, like for example Security.

Also when the page will be updated to utilize the new platform labels, it should be easier for users to see that the property is only available for the iOS platform.

So at this moment of time, I think that the change is not that necessary.

@Simek Simek closed this Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants