Disable web-preview for TextStyleProps example #2656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`react-native-web` does not support the deprecated `Slider` component causing the example to fail with a React minified error upon loading the page.
|
✔️ Deploy Preview for react-native ready! 🔨 Explore the source changes: 00c007c 🔍 Inspect the deploy log: https://app.netlify.com/sites/react-native/deploys/60d4555d28eee00007c3f285 😎 Browse the preview: https://deploy-preview-2656--react-native.netlify.app |
Simek
approved these changes
Jun 24, 2021
There was a problem hiding this comment.
Hi @IjzerenHein, thank you for catching this issue out and pushing the fix! 🙂
Your welcome, LGTM :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
react-native-webdoes not support the deprecatedSlidercomponent causing theTextStylePropsexample to fail with a React minified error upon loading the page.As discussed here:
#2476 (comment)
@Simek
before
after
How
iosandandroidWhy
yarn prettierto verify the file doesn't contain any styling issues