Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update scrollview.md adding new prop automaticallyAdjustsScrollIndicatorInsets #2661

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Update scrollview.md adding new prop automaticallyAdjustsScrollIndicatorInsets #2661

merged 1 commit into from
Aug 17, 2021

Conversation

justinwh
Copy link
Contributor

Adds the new prop automaticallyAdjustsScrollIndicatorInsets to the docs for ScrollView.

Prop added here: facebook/react-native#29809

@justinwh justinwh mentioned this pull request Jun 30, 2021
Closed
@netlify
Copy link

netlify bot commented Jun 30, 2021 •
edited
Loading

✔️ Deploy Preview for react-native ready!

🔨 Explore the source changes: 853e463

🔍 Inspect the deploy log: https://app.netlify.com/sites/react-native/deploys/60e60a8e999dc900076f33a7

😎 Browse the preview: https://deploy-preview-2661--react-native.netlify.app

@Simek Simek added the Wait on future Release This indicates a PR that updates the doc to match a future release. label Jun 30, 2021
lunaleaps
lunaleaps reviewed Jul 7, 2021
View reviewed changes
docs/scrollview.md Outdated Show resolved Hide resolved
@lunaleaps
Copy link
Contributor

@justinwh Let me know what you think about my suggestion! Otherwise looks good to me!

@Simek what does the tag Wait on future release indicate? Let me know if there's a doc explaining this that I'm missing

@Simek
Copy link
Collaborator

Simek commented Jul 7, 2021

@Simek what does the tag Wait on future release indicate? Let me know if there's a doc explaining this that I'm missing

The description is avaible on the labels list - https://github.com/facebook/react-native-website/labels - shortly, it means that the PR adds a docs change which will be a part of future release, beyond next version, which on 0.65 release becomes 0.65 docs.

Also this PR is missing "Waiting on PR" label, since the main repository PR has not been merged yet.

@Simek Simek added the 🕐 Waiting on PR These may be waiting for a PR to the facebook/react-native to be merged label Jul 7, 2021
@justinwh justinwh force-pushed the scrollview-automaticallyAdjustsScrollIndicatorInsets branch from 954d78d to 853e463 Compare July 7, 2021 20:11
@Simek Simek removed the 🕐 Waiting on PR These may be waiting for a PR to the facebook/react-native to be merged label Jul 8, 2021
@lunaleaps
Copy link
Contributor

lunaleaps commented Jul 8, 2021 •
edited
Loading

@Simek Gotcha! Thanks for explaining! That's right, this would be beyond next. Does that inhibit us from merging?

@Simek Simek merged commit 4d71625 into facebook:master Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunaleaps lunaleaps lunaleaps approved these changes

Assignees
No one assigned
Labels
CLA Signed Wait on future Release This indicates a PR that updates the doc to match a future release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@justinwh @lunaleaps @Simek @facebook-github-bot