Update ScrollView document to add pointerEvents prop #2936
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for react-native ready! 🔨 Explore the source changes: c691105 🔍 Inspect the deploy log: https://app.netlify.com/sites/react-native/deploys/61ea17037ba8200007faedfd 😎 Browse the preview: https://deploy-preview-2936--react-native.netlify.app |
|
Hi @ryancat, thank you for the update suggestion! 👍 Unfortunately In cases like this we avoid the prop duplication on the child component, because otherwise list of the props will be quite overwhelming and maintaining the multiple instances of the same prop in various pages would be difficult and it would be easy to miss one when updating the docs. Hope you understand that! 🙂 |
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Jan 21, 2022
Summary: Per discussion in the previous diff D33672110, it's ok to add the `pointerEvents` prop to scrollview. This will help prevent scrolling on the ScrollView if pointerEvents is set to `box-none`, or `none`. Corresponding doc changes are in facebook/react-native-website#2936 Changelog: [Android][Added] - Add new API in ScrollView and HorizontalScrollView to process pointerEvents prop. Reviewed By: javache Differential Revision: D33699223 fbshipit-source-id: 1cae5113e9e7d988fc4c4765c41d817a321804c4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.