Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Social Banner in Support of Ukraine #2986

Merged
merged 3 commits into from
Mar 2, 2022

Conversation

dmitryvinn
Copy link
Contributor

Summary

Our mission at Meta Open Source is to empower communities through open source, and we believe that it means building a welcoming and safe environment for all. As a part of this work, we are adding this banner in support for Ukraine during this crisis.

Testing

image

@netlify
Copy link

netlify bot commented Mar 2, 2022

✔️ Deploy Preview for react-native ready!

🔨 Explore the source changes: 3acee76

🔍 Inspect the deploy log: https://app.netlify.com/sites/react-native/deploys/621eefeb1dd69200080976a0

😎 Browse the preview: https://deploy-preview-2986--react-native.netlify.app

@dmitryvinn-fb dmitryvinn-fb requested a review from Simek March 2, 2022 04:24
@dmitryvinn-fb
Copy link
Contributor

Note: following this PR, we will be closing facebook/react-native#33192

Copy link
Collaborator

@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use announcement banner feature for this, instead of implementing custom component?

We have used this feature before in few occasions and it should looks something like that:

@yungsters
Copy link
Contributor

In the spirit of getting this published as soon as possible, I'm merging this. But let's fix forward if we believe this can be done better.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants