Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeScript support in New Architecture/Codegen #3036

Merged
merged 5 commits into from
Apr 13, 2022

Conversation

charlesbdudley
Copy link
Contributor

@charlesbdudley charlesbdudley commented Mar 29, 2022

Updated the documentation to specify that TypeScript spec files are supported, with examples for both TurboModules and Fabric Components

@netlify
Copy link

netlify bot commented Mar 29, 2022

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit 6f57418
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/6257312855f5ef0009e63fee
😎 Deploy Preview https://deploy-preview-3036--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! 👏 I'm excited because it will help us also in other pieces of doc work we are carrying on.

I left a few suggestions here and there to improve homogeneity of the documentation and clarity, plus a question about TurboModules types.

docs/new-architecture-library-intro.md Outdated Show resolved Hide resolved
docs/new-architecture-library-intro.md Outdated Show resolved Hide resolved
docs/new-architecture-library-intro.md Outdated Show resolved Hide resolved
docs/new-architecture-library-intro.md Outdated Show resolved Hide resolved
docs/new-architecture-library-intro.md Outdated Show resolved Hide resolved
Copy link
Contributor

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @charlesbdudley 👍

@Titozzz might have some opinions to share on this as well

docs/new-architecture-library-intro.md Outdated Show resolved Hide resolved
docs/new-architecture-library-intro.md Outdated Show resolved Hide resolved
docs/new-architecture-library-intro.md Outdated Show resolved Hide resolved
docs/new-architecture-library-intro.md Outdated Show resolved Hide resolved
docs/new-architecture-library-intro.md Outdated Show resolved Hide resolved
@charlesbdudley charlesbdudley changed the title [WIP] Add TypeScript support in New Architecture/Codegen Add TypeScript support in New Architecture/Codegen Mar 31, 2022
Copy link
Contributor

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Accepting to unblock you

website/core/TabsConstants.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants