Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] TurboModules guide #3168

Merged
merged 35 commits into from
Jul 20, 2022
Merged

[FEAT] TurboModules guide #3168

merged 35 commits into from
Jul 20, 2022

Commits on Jul 7, 2022

  1. [Feat] Add intro for Fabric Components

    Riccardo Cipolleschi committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    3e229de View commit details
    Browse the repository at this point in the history

  2. feat: add guide to create a Fabric Component

    Riccardo committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    94ff5bf View commit details
    Browse the repository at this point in the history

  3. Beginning of guide/folder structure

    @lindboe
    lindboe committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    00f2ba5 View commit details
    Browse the repository at this point in the history

  4. WIP JS Spec

    @lindboe
    lindboe committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    7ab79be View commit details
    Browse the repository at this point in the history

  5. specification section

    @lindboe
    lindboe committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    221bb9f View commit details
    Browse the repository at this point in the history

  6. Configuration

    @lindboe
    lindboe committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    681992b View commit details
    Browse the repository at this point in the history

  7. native code intro

    @lindboe
    lindboe committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    a5d4194 View commit details
    Browse the repository at this point in the history

  8. Must be named Spec

    @lindboe
    lindboe committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    07f72f7 View commit details
    Browse the repository at this point in the history

  9. Best stab at iOS native code, but I don't know how to describe what's… 

    … going on in the code very well. Extrapolated what I could.
    @lindboe
    lindboe committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    7c5fea3 View commit details
    Browse the repository at this point in the history

  10. Android instructions 

    iOS isn't working for me. Builds, but can't load module.

Writing up Android auto-linking next because the steps I tested did
work.
    @lindboe
    lindboe committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    4b6d2cf View commit details
    Browse the repository at this point in the history

  11. Include linking instructions from RNNArch repo

    @lindboe
    lindboe committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    1706d64 View commit details
    Browse the repository at this point in the history

  12. Add example JavaScript

    @lindboe
    lindboe committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    a5de9ee View commit details
    Browse the repository at this point in the history

  13. native modules link

    @lindboe
    lindboe committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    75df78c View commit details
    Browse the repository at this point in the history

  14. Address quick feedback items

    @lindboe
    lindboe committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    102df77 View commit details
    Browse the repository at this point in the history

  15. Remove, fix for rebased branch

    @lindboe
    lindboe committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    cc7ab86 View commit details
    Browse the repository at this point in the history

  16. fix TM parameter on Android

    @lindboe
    lindboe committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    9356fb1 View commit details
    Browse the repository at this point in the history

  17. Revert to 'Codegen' casing

    @lindboe
    lindboe committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    f94cc72 View commit details
    Browse the repository at this point in the history

  18. Revert folly version change 

    2021.07.22 is for current version on main
    @lindboe
    lindboe committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    5b12472 View commit details
    Browse the repository at this point in the history

  19. fix typo

    @lindboe
    lindboe committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    c671f49 View commit details
    Browse the repository at this point in the history

  20. getTurboModule explainer

    @lindboe
    lindboe committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    348ec2f View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2022

  1. Sentence edits 

    - Fix acronym bolding
- Change wording to "recommended" because "standard" has other
  connotations of possibly being required
- Parentheses unnecessary, distracting
    @lindboe
    lindboe committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    b1a870d View commit details
    Browse the repository at this point in the history

  2. Remove TODO for now 

    Getting inconsistent results here, not sure if this is wrong or not;
removing TODO for now so it doesn't block anything
    @lindboe
    lindboe committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    575583f View commit details
    Browse the repository at this point in the history

  3. ABI rephrase, more in line with new Fabric guide wording

    @lindboe
    lindboe committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    70633bf View commit details
    Browse the repository at this point in the history

  4. Explain shared C++ code more

    @lindboe
    lindboe committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    23aec94 View commit details
    Browse the repository at this point in the history

  5. feat: add guide to create a Fabric Component

    Riccardo committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    f2dbfa8 View commit details
    Browse the repository at this point in the history

  6. merge upstream

    Riccardo Cipolleschi committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    3d376f2 View commit details
    Browse the repository at this point in the history

  7. feat: add guide to create a Fabric Component

    Riccardo committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    544827a View commit details
    Browse the repository at this point in the history

  8. pull from upstream

    Riccardo Cipolleschi committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    eede426 View commit details
    Browse the repository at this point in the history

  9. package.json description

    @lindboe
    lindboe authored and Riccardo Cipolleschi committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    560a268 View commit details
    Browse the repository at this point in the history

  10. Lint fixes

    @lindboe
    lindboe authored and Riccardo Cipolleschi committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    bd4778e View commit details
    Browse the repository at this point in the history

  11. fix: Move JS constants to reduce changes

    Riccardo Cipolleschi committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    736f5c5 View commit details
    Browse the repository at this point in the history

  12. fix: Remove newline

    Riccardo Cipolleschi committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    62a581a View commit details
    Browse the repository at this point in the history

  13. feat: add required step for Android Codegen

    Riccardo Cipolleschi committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    9060265 View commit details
    Browse the repository at this point in the history

  14. fix: use the proper links

    Riccardo Cipolleschi committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    3dde742 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2022

  1. Merge branch 'feat/new-architecture-guide-refactoring' into feat/tna-… 

    …turbomodules
    Riccardo authored Jul 20, 2022
    Configuration menu
    Copy the full SHA
    397c0dc View commit details
    Browse the repository at this point in the history