Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update snippet in profile-hermes to be Groovy rather than Java #3193

Merged
merged 1 commit into from
Jul 5, 2022

Conversation

cortinico
Copy link
Contributor

This is a nit, but I've realized that this snippet inside profile-hermes was originally marked as Java code while in reality is Groovy code (as it's from a .gradle file).

@netlify
Copy link

netlify bot commented Jul 5, 2022

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit 86ae167
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/62c40e7d8d3e8a00095bb4a5
😎 Deploy Preview https://deploy-preview-3193--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Collaborator

@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@cortinico cortinico merged commit 09447e6 into main Jul 5, 2022
@cortinico cortinico deleted the nc/groovy-snippet branch July 5, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants