Showcase page refresh #3235

Simek · 2022-08-01T14:20:01Z

Why

We plan to expose the link to this page in the top navbar, so I thought that a small design and data refresh before that exposure will be nice.

How

This PR refreshes the Showcase page design, content now spans to the same with as other custom pages, header and footer content has been moved to the separate sections.

The apps list also has been updated:

partners apps are grouped at the top of the showcase: boxes includes partner logo - take from the official brand resources - and optional description/testimonial which need to be filled - I have no content for those places, so I have used Lorem Ipsum and one example there,
the rest of the entries are shuffled on each render.

Additionally I have updated few of the existing entries, outdated icons (using app assets from on of the stores page) and I have removed few entries, as established when reassessing the current Showcase content.

Tests

The changes have been tested by running docs website locally. Mobile layout has been tested on the real device.

Preview

Deploy: https://deploy-preview-3235--react-native.netlify.app/showcase

Full page screenshots

netlify · 2022-08-01T14:24:47Z

✅ Deploy Preview for react-native ready!

Name	Link
🔨 Latest commit	`c01928c`
🔍 Latest deploy log	https://app.netlify.com/sites/react-native/deploys/62e7e11301d7b90008bdf746
😎 Deploy Preview	https://deploy-preview-3235--react-native.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify · 2022-08-01T14:30:20Z

✅ Deploy Preview for react-native ready!

Name	Link
🔨 Latest commit	`7a64c91`
🔍 Latest deploy log	https://app.netlify.com/sites/react-native/deploys/630662349aa5180009b1ba0c
😎 Deploy Preview	https://deploy-preview-3235--react-native.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

kelset

great stuff! I'm adding a few suggestions here and there.

website/src/pages/showcase.js

kelset · 2022-08-08T13:52:48Z

website/src/pages/showcase.js

+            Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nullam sit
+            amet ex ullamcorper, dignissim elit ac, ornare elit. Donec iaculis,
+            erat in pharetra euismod, sem ipsum varius urna, nec hendrerit nisi
+            urna sed lorem.


just a placeholder comment to pin where we need to address the lorem ipsum (this is the Meta one). @lunaleaps / @rickhanlonii can you suggest what to write here?

"React Native is shaping mobile, web, and desktop experiences within Meta’s product ecosystem, from Facebook Marketplace, Messenger Desktop, Ads Manager to the Oculus companion app and many more"

kelset · 2022-08-08T13:54:27Z

website/src/pages/showcase.js

+            EXAMPLE: After years of native mobile development, we’ve decided to
+            go full steam ahead building all of our new mobile apps using React
+            Native.
+            <br />
+            Read more about it on our{' '}
+            <a href="https://shopify.engineering/topics/mobile" target="_blank">
+              Engineering Blog
+            </a>
+            .


placeholder comment to get final ✅ from the Shopify folks. cc @fortmarek, @colinta

This is what we'd like to have here instead:

All new mobile apps at Shopify are React Native and we are actively migrating our flagship merchant admin app Shopify Mobile to React Native as well. You can read more about React Native development at Shopify on our [blog](https://shopify.engineering/topics/mobile).

cc @Simek let me know if that works in the context of the showcase 👀

website/src/pages/showcase.js

Co-authored-by: Lorenzo Sciandra <lorenzo.sciandra@gmail.com>

website/showcase.json

Co-authored-by: Lorenzo Sciandra <lorenzo.sciandra@gmail.com>

website/src/pages/showcase.js

Co-authored-by: Lorenzo Sciandra <lorenzo.sciandra@gmail.com>

lunaleaps · 2022-08-16T19:50:21Z

website/src/pages/showcase.js

+            href={app.infoLink}
+            target="_blank"
+            title={app.infoTitle}>
+            Learn more{' '}


Have we thought about removing these learn more links? They often lead to really stale content

those that were really stale have been addressed (ex. we replaced the Discord link with the new blogpost about Android). If you have found more of those, let us know and we can remove them - but I'd leave the option of have the "learn more" button.

I think that it's important to have those links that will lead people to the companies' own words, talks, etc as a way to "back" the fact that they are in the showcase. Like, I honestly prefer when there's a "learn more" button so that I can actually hear/read what the company has to say around RN and their usage (which is also something that annoys me about MSFT apps 🤣 we only have talks at confs and no blogpost to link 😰 will work on changing that in the future I swear)

Can we remove the "Learn More" links for Facebook, Ads Manager. As well, can we remove Instagram as an app? We can probably add Messenger Desktop and use https://reactnative.dev/blog/2021/08/26/many-platform-vision#expanding-to-new-platforms as the link?

I will remove the links in next commit, but if you can suggest the changes for the listed apps it would be nice.

lunaleaps · 2022-08-17T18:35:48Z

Some UI points:

Can we scale down the app icon sizes (on the showcase page), they are quite large in relation to the company logo. Perhaps they could be similar size to the home page apps?

Can we remove the drop shadows on the company boxes? I don't see us putting drop shadows on any other content that has borders. I think adding drop shadows on the app icons is a great addition

Something like:

Simek · 2022-08-17T19:44:53Z

Can we scale down the app icon sizes (on the showcase page), they are quite large in relation to the company logo.

The icons size did not change from the currently deployed showcase, I can try to reduce the sizing a bit, but I think that similar size to the pinned apps on home page will be too small.

Can we remove the drop shadows on the company boxes?

I was iterating on this design, and initially, the company boxes have no shadows but then then I have added one for icons and went with same style for boxes, but I agree that it's not a pattern or style that we use anywhere else on the website. I have also experimented with no borders and altered background section like on the home page, but it doesn't look good. Going to remove the shadow, please let me know if this looks fine after that change.

lunaleaps · 2022-08-17T19:48:38Z

Thanks @Simek! -- sorry for the delay, I also tried it out and added a screenshot to my comment above. Generally, I'm looking for the page to take less vertical space

Simek · 2022-08-17T20:03:07Z

@lunaleaps Can you check the preview deploy, when the updated version with the latest commit will be deployed, and let me know if the changes improved the appearance and address the concerns you have? I have reduce the icons size from 100px to 80px and tweaked spacing a bit.

Also, as stated before, to reduce the vertical space taken even more we can "stick" the "Learn more" button to the bottom border of the app tile. Would you like to see change like this in?

Preview

lunaleaps · 2022-08-17T22:26:43Z

Great thank you @Simek! I do like the sticky "learn more" -- and I guess if there was no "learn more" link, the height would be fixed so things stay flushed?

Some other nits (in order of importance)

Fix dark mode, we probably want the background to be the same color as the header?
Can we +1 to number of showcase-icons in each breakpoint? Like for example, I think we should fit 3 in here
Changes to the header to take up less vertical space
- Can we change the black header paddingTop, paddingBottom: 20 -- or something similar to other pages -- I notice they all have around 20px at top (example)
- Update the text to not have a <br />
- Update the "React Native" text to be white
- There looks like an undefined CSS class
There's a certain width where there is no margin on the company section border screenshot

If you agree, I can also take a stab at these updates -- or we can do them in a follow-up.

Simek · 2022-08-18T14:57:02Z

Thank you for the review and suggestions @lunaleaps! 👍

I do like the sticky "learn more" -- and I guess if there was no "learn more" link, the height would be fixed so things stay flushed?

Height of the row is determined by the highest element and rest is stretched to match it. I will change the "Lear More" button styling in next commit.

Fix dark mode, we probably want the background to be the same color as the header?

I think this is the expected results, since we use theme variables. You can see that even on Home page the header and darker section on the home page have the different colors.

Can we +1 to number of showcase-icons in each breakpoint? Like for example, I think we should fit 3 in here

Hmm, I'm afraid that then entries will be too cramped/narrow. Below you can see the minim width for displaying 3 tiles now, if we switch to 4 in there we can end up with 3 lines titles, which will lead to extended vertical space taken.

Can we change the black header paddingTop, paddingBottom: 20 -- or something similar to other pages -- I notice they all have around 20px at top (example)

The hero header uses the generic styles Section component styles, like all section on the homepage. We can alter that padding, but it will require adding custom CSS overwrites, not a fan of this approach, but can do that if you insist.

Update the text to not have a <br />

The idea here was to add some kind of illustration on the right side, but until we do not have an asset which we can use there, it will be fine to remove <br/>.

Update the "React Native" text to be white

This styling was inspired based on home page again, can alter that, but I personally prefer the highlight color.

There looks like an undefined CSS class

Nice catch, this will be fixed soon. 🙂

There's a certain width where there is no margin on the company section border screenshot

Again nice catch, this was not intended, will fix it in the next commit.

lunaleaps · 2022-08-18T23:36:03Z

Thanks @Simek for the detailed responses!

Re: dark mode - Sounds good.
Re: showcase icons per breakpoint - okay let's keep it as is then.
Re: hero header - Can we remove it as a header and have it flat on the background? Similar to our docs?
Re: React Native color - Similar to previous point, if we keep it as a hero header I can see what you mean but I think the information/content there now is very low value, I'm not sure we need to highlight it since our company/app logos are already the highlight.

Other than that, these changes look good to me! I think these UI changes are the last thing before we can land this?

kelset · 2022-08-19T08:47:01Z

Other than that, these changes look good to me! I think these UI changes are the last thing before we can land this?

I think so :) let's gooooo 🥳

website/showcase.json

lunaleaps

Feel free to merge when you're ready!

@Titozzz

* Add a few Microsoft apps to the showcase (facebook#3203) * fix artsy icon * add microsoft office mobile * add outlook mobile * add teams * add xbox * remove placeholder link * Correct minor mistake in native-components-android.md (facebook#3210) * Update fast-refresh.md (facebook#3208) Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com> * Fixed Artsy logo and infoLink of oculus in webiste/showcase (facebook#3199) * Wrap "Android SDK Build-Tools" with backticks (facebook#3206) * Update keyboardavoidingview.md (facebook#3202) * Update debugging.md (facebook#3209) * Add the blogpost for Hermes as the Default engine (facebook#3212) * Add the blogpost for Hermes as the Default engine * Update website/blog/2022-07-08-hermes-as-the-default.md Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com> * Update website/blog/2022-07-08-hermes-as-the-default.md Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com> Co-authored-by: Nicola Corti <corti.nico@gmail.com> Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com> * Update iOS data in Hermes default blog post (facebook#3216) * Update the contributing section docs (facebook#3221) Co-authored-by: Nicola Corti <corti.nico@gmail.com> Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com> * Bump terser from 5.12.1 to 5.14.2 (facebook#3219) Bumps [terser](https://github.com/terser/terser) from 5.12.1 to 5.14.2. - [Release notes](https://github.com/terser/terser/releases) - [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md) - [Commits](https://github.com/terser/terser/commits) --- updated-dependencies: - dependency-name: terser dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * docs: add build tools to Table of Contents (facebook#3228) * Update build-speed.md (facebook#3223) Removed duplicated sentence from docs * Remove Uber Eats from showcase (facebook#3229) * docs: add two sections to the New Architecture (facebook#3230) * Note on connecting to React Native simulator. (facebook#3214) Co-authored-by: LeoTM <1881059+leotm@users.noreply.github.com> Co-authored-by: Nicola Corti <corti.nico@gmail.com> * Fix a couple of problems on the release runbook (facebook#3222) * Improving UX: replace videos and links with SnackPlayers, update examples (facebook#3231) * Fix extra whitespace on debugging.md (facebook#3233) * Add more info to Prerequisites for Libraries guide (facebook#3238) * Add spaces in the example * Add section about codegen types * Correct section title * Add information about requireNativeComponent * [Docs] iOS Simulator version & UDID (facebook#3225) Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com> * Add retrospective as a copilot responsibility (facebook#3242) * update release related docs page (facebook#3240) * update crew composition and remove testers/supporters * add note about testing async * Update website/contributing/release-roles-responsibilites.md Co-authored-by: Riccardo <riccardo.cipolleschi@gmail.com> * Update website/contributing/release-roles-responsibilites.md Co-authored-by: Riccardo <riccardo.cipolleschi@gmail.com> * refactor note into a snipper * Update website/contributing/release-roles-responsibilites.md Co-authored-by: Marek Fořt <marekfort@me.com> * yarnlock change? * clean up document based on feedback * more words at the start Co-authored-by: Riccardo <riccardo.cipolleschi@gmail.com> Co-authored-by: Marek Fořt <marekfort@me.com> * Update image.md (facebook#2850) This is missing, but this is an important information. Imagine a view sized 100x150 and an image sized 200x300. The old description could be interpreted in a way, that the image doesn't scale at all! * Fix lint * chore: Specify return vs resolve (facebook#3236) When dealing with functions which return Promises, it's helpful to be clear about whether something _returns_ a value, or whether the returned Promise will _resolve to_ a value. * update Docusaurus and other dependencies (facebook#3218) * Add kotlin examples in new-architecture-app-modules-android.md (facebook#3241) * change links in main home (facebook#3244) * Refactoring The New Architecture Guide (facebook#3037) * [Do Not Merge] Refactoring The New Architecture (facebook#3029) * [Guide - The New Architecture] What Backward Compatibility Is (facebook#3038) * Guide to creating a New Architecture app from template (facebook#3056) * Start new template guide This is a first iteration. I want to get feedback on a few aspects, so starting from here as a baseline. * Update title * Use tabs for target OS Set up matching the style of "Getting Started", except I kept the headers inside the tabs for now as it makes for a useful right-hand TOC. * Capitalize New Architecture, simplify * Preliminary section for Hermes Add section for recommending enabling Hermes. Not sure of contents yet, and still have to test. * Reword to emphasize importance of Hermes usage * Show new arch in use * Add build speed article link * Add pro tip for pod install alias * Restructure, repeat less Favor linking to original setup guide instead of repeating content. * Note about Expo * Include command on uninstalling global CLI * How to learn more * Remove headers in tabs They don't work correctly with the righthand TOC. * Make header more clear * Use quote block less often There was way too much yellow. * Opt for instructions using XCode Because `xcodebuild clean` already failed me once when XCode GUI clean worked. * Fix lint issue * Improve wording * Use product name * Fix line wraps * Reword based on feedback * Note use of bundle install * Pod removal instructions Also standardize on using yarn scripts from template for commands, it's a little confusing to see the mix of `npx` and `yarn` once we start referring to `yarn pod-install` * Convert quotes to admonitions * Convert Note: to admonitions * Feedback: Change admonitions to caution * PR feedback * New Architecture landing page (facebook#3072) * First draft of landing page * Add migration and backwards compatibility links * lint fix * Restructure slightly, leaning more on context from Why a New Architecture * Don't need md in links * Suggested rewording * Rephrase pillar summaries * [Guide - The New Architecture] Why A New Architecture (facebook#3043) * [Guide - The New Architecture] Pillars (facebook#3046) * [Guide - The New Architecture] TurboModules as Native Modules (facebook#3039) * [Guide - The New Architecture] Fabric Components as Native Components (facebook#3040) * [FEAT][TNA] Fabric Component Guide (facebook#3132) * [Feat] Add intro for Fabric Components * feat: add guide to create a Fabric Component * Add page on codegen (facebook#3155) * [FEAT] TurboModules guide (facebook#3168) * [Feat] Add intro for Fabric Components * feat: add guide to create a Fabric Component * Beginning of guide/folder structure * WIP JS Spec * specification section * Configuration * native code intro * Must be named Spec * Best stab at iOS native code, but I don't know how to describe what's going on in the code very well. Extrapolated what I could. * Android instructions iOS isn't working for me. Builds, but can't load module. Writing up Android auto-linking next because the steps I tested did work. * Include linking instructions from RNNArch repo * Add example JavaScript * native modules link * Address quick feedback items * Remove, fix for rebased branch * fix TM parameter on Android * Revert to 'Codegen' casing * Revert folly version change 2021.07.22 is for current version on main * fix typo * getTurboModule explainer * Sentence edits - Fix acronym bolding - Change wording to "recommended" because "standard" has other connotations of possibly being required - Parentheses unnecessary, distracting * Remove TODO for now Getting inconsistent results here, not sure if this is wrong or not; removing TODO for now so it doesn't block anything * ABI rephrase, more in line with new Fabric guide wording * Explain shared C++ code more * feat: add guide to create a Fabric Component * feat: add guide to create a Fabric Component * package.json description * Lint fixes * fix: Move JS constants to reduce changes * fix: Remove newline * feat: add required step for Android Codegen * fix: use the proper links Co-authored-by: Riccardo Cipolleschi <cipolleschi@fb.com> * wip: migration guide review (facebook#3200) Co-authored-by: Lizzi Lindboe <lindboe@users.noreply.github.com> * fix: Fix typo in the sidebar (facebook#3247) * Delete ubereats.png (facebook#3246) Redundant image data * Fixed pod install instructions (facebook#3243) * Fixed pod install instructions Yarn must be run prior to pod install, otherwise pod install fails with "Error: Cannot find module 'mkdirp'" * yarn start is not necessary anymore * Refer to rntester readme * Update android studio screenshot (facebook#3253) * Adding Android 13 Permissions into PermissionsAndroid (facebook#3254) * TextInput: Add cursorColor Android prop (facebook#3255) * Update Android Studio screenshot (Windows) (facebook#3257) * docs (releases): small refactoring and updating templates (facebook#3256) * Update documentation for keyboard events on Android (facebook#3259) facebook/react-native@1e48274 fixed keyboard events on Android 11+ when an activity has set `android:windowSoftInputMode` to `adjustNothing`. Update the documentation to reflect the change. * Update to Docusaurus stable release, fix alert admonition styling (facebook#3248) * Change asks to ask (grammar) (facebook#3262) * contributing: remove old references (facebook#3263) * adding accessibilityLabelledBy to documentation (facebook#3249) * Update references to Expo / Expo CLI (facebook#3267) * feat(images): Adding iOS Image Cache Limits (facebook#3258) Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com> * feat: update instructions around automatic linking (facebook#3269) * Follow up from facebook#3267 with minor fixes (facebook#3270) * nit: fix typo in new architecture docs (facebook#3261) * fix typo * fix: typescript example * fix: lint * make text optional * fix(images): move app-transport-security reference (facebook#3271) * fix(images): move app-transport-security reference * feat(images): updating link references * fix(network): change network app transport security reference * fix(docs): updating versioned docs link reference * Showcase page refresh (facebook#3235) Co-authored-by: Lorenzo Sciandra <lorenzo.sciandra@gmail.com> * fix: moving the Using forwardRef and Using a getter to a lower hierarchy level (facebook#3282) * Upgrade toast Android example to camelCase (facebook#3283) * Fix link in Introduction (facebook#3290) * Fix link in Introduction * Use new page title (potentially renaming that is a separate discussion) * fix: push steps in a lower hierarchy level (facebook#3296) * fix type in the new architecture pillars section (facebook#3297) * cut 0.70 docs (take 2) (facebook#3295) * Blog post for 0.70 RN release (facebook#3298) * Blog post for 0.70 RN release * Fixes and TOC * Update my GH handle * Update my GH handle * Apply suggestions from code review Co-authored-by: Riccardo <cipolleschi@fb.com> * Update @Titozzz Twitter handle * Add example for javaPackageName * Update commits count * Minor fixes to the wording Co-authored-by: Dmytro Rykun <dmitry.rykun@gmail.com> Co-authored-by: Riccardo <cipolleschi@fb.com> Co-authored-by: Lorenzo Sciandra <notkelset@kelset.dev> Co-authored-by: Marcin Kozubek <mkozubek@protonmail.com> Co-authored-by: Malachi Gruenhagen <68450431+nurse-the-code@users.noreply.github.com> Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com> Co-authored-by: Pushkar Yadav <96358784+pushkarydv@users.noreply.github.com> Co-authored-by: Muhammad Ovi (Owais) <muhammadowaisnaseem@gmail.com> Co-authored-by: rj-jones <85085648+rj-jones@users.noreply.github.com> Co-authored-by: fbmal7 <105675860+fbmal7@users.noreply.github.com> Co-authored-by: Nicola Corti <corti.nico@gmail.com> Co-authored-by: neildhar <neildhar@users.noreply.github.com> Co-authored-by: Lorenzo Sciandra <lsciandra@microsoft.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Yvan Zhu <i@zhuyunfeng.com> Co-authored-by: Mileta Dulović <dulovicmileta1@gmail.com> Co-authored-by: Ricky <rickhanlonii@fb.com> Co-authored-by: Andrew <35735666+meatnordrink@users.noreply.github.com> Co-authored-by: LeoTM <1881059+leotm@users.noreply.github.com> Co-authored-by: Nicola Corti <ncor@fb.com> Co-authored-by: Oskar Kwaśniewski <oskarkwasniewski@icloud.com> Co-authored-by: Furkan Arabacı <furkanarabaci@hotmail.com> Co-authored-by: Marek Fořt <marekfort@me.com> Co-authored-by: Riccardo <riccardo.cipolleschi@gmail.com> Co-authored-by: Władysław Raczek <wsw.raczek@gmail.com> Co-authored-by: Luna Wei <luwe@fb.com> Co-authored-by: Evan Charlton <evancharlton@gmail.com> Co-authored-by: Tushar Varshney <110495886+tusharvars@users.noreply.github.com> Co-authored-by: Riccardo <cipolleschi@fb.com> Co-authored-by: Lizzi Lindboe <lindboe@users.noreply.github.com> Co-authored-by: Jessej Samuel <1234jessej@gmail.com> Co-authored-by: Seph Soliman <seph@seph.dk> Co-authored-by: Kimiyasu Morikawa <mail@alea12.net> Co-authored-by: Agastya Darma <gedeagas22@gmail.com> Co-authored-by: Nick Gerleman <nick@nickgerleman.com> Co-authored-by: denis-tsoi-mox <67885203+denis-tsoi-mox@users.noreply.github.com> Co-authored-by: fabriziobertoglio1987 <fabrizio.bertoglio@gmail.com> Co-authored-by: Brent Vatne <brentvatne@gmail.com> Co-authored-by: Michał Pierzchała <thymikee@gmail.com> Co-authored-by: nishan (o^▽^o) <nishanbende@gmail.com> Co-authored-by: Lorenzo Sciandra <lorenzo.sciandra@gmail.com> Co-authored-by: Lucas Alves <lcsjalves@gmail.com> Co-authored-by: dan <dan.abramov@gmail.com> Co-authored-by: Dmytro Rykun <dmitry.rykun@gmail.com>

Simek added 2 commits July 27, 2022 16:12

showcase refresh draft

9fd476f

remove Uber entry and logos

c01928c

Simek added Design For things that change the design, CSS, layout, etc of the site. Needs testing in multiple browsers Showcase labels Aug 1, 2022

facebook-github-bot added CLA Signed p: expo Partner labels Aug 1, 2022

Merge branch 'main' into showcase-refresh

4c03be7

Simek added 6 commits August 1, 2022 16:47

apps tile key fix

318f7cf

fix hydration issue

9683ce0

update entries and icons, remove FB Analytics due to sunset

c1540b5

improve learn more button, correct Shopify icon

47b668c

fix build error, update entry, remove Vogue

cef142e

small tweaks for the home page showcase

4906f81

Simek mentioned this pull request Aug 6, 2022

feat: add Discord android playstore link #3245

Closed

Simek added 2 commits August 6, 2022 09:55

few more updates and corrections based on the audit

a9c91d1

correct naming, use infoTitle, update links

51387ca

kelset reviewed Aug 8, 2022

View reviewed changes

Simek mentioned this pull request Aug 9, 2022

remove fb analytics image in showcase #3251

Closed

Simek and others added 3 commits August 9, 2022 21:33

Apply suggestions from code review

c2968ab

Co-authored-by: Lorenzo Sciandra <lorenzo.sciandra@gmail.com>

address review, restructure JSON, fix lint, update entries

69cebec

small app tile style touches, might revert in future

4a8eb27

Simek mentioned this pull request Aug 10, 2022

Update link to Flipkart's blog #3252

Closed

kelset mentioned this pull request Aug 10, 2022

Modify the top navbar to be less full #3177

Merged

kelset reviewed Aug 10, 2022

View reviewed changes

website/showcase.json Outdated Show resolved Hide resolved

update FlipKart URL

f4b81de

Co-authored-by: Lorenzo Sciandra <lorenzo.sciandra@gmail.com>

Simek changed the title ~~[WIP] Showcase page refresh~~ Showcase page refresh Aug 10, 2022

Simek marked this pull request as ready for review August 10, 2022 13:46

kelset reviewed Aug 10, 2022

View reviewed changes

website/src/pages/showcase.js Outdated Show resolved Hide resolved

Simek and others added 3 commits August 11, 2022 11:26

Update website/src/pages/showcase.js

d12f318

Co-authored-by: Lorenzo Sciandra <lorenzo.sciandra@gmail.com>

fix lint

a7ef41c

small spacing tweaks

7d2f3bf

lunaleaps reviewed Aug 16, 2022

View reviewed changes

update the users showcase logic

fa28860

replace placeholder copy, apply review suggestions

2d645e1

another batch of review suggestions

ad6f5bc

lunaleaps reviewed Aug 19, 2022

View reviewed changes

website/showcase.json Outdated Show resolved Hide resolved

remove Instagram as requested, small spacing tweak

7a64c91

lunaleaps approved these changes Aug 24, 2022

View reviewed changes

Simek merged commit 133f5fa into facebook:main Aug 25, 2022

Simek deleted the showcase-refresh branch August 25, 2022 09:09

kelset mentioned this pull request Sep 16, 2022

showcase: update entries #3328

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Showcase page refresh #3235

Showcase page refresh #3235

Simek commented Aug 1, 2022 •

edited

Loading

netlify bot commented Aug 1, 2022

netlify bot commented Aug 1, 2022 •

edited

Loading

kelset left a comment

kelset Aug 8, 2022

lunaleaps Aug 17, 2022

kelset Aug 8, 2022

fortmarek Aug 16, 2022

lunaleaps Aug 16, 2022

kelset Aug 17, 2022 •

edited

Loading

lunaleaps Aug 17, 2022

Simek Aug 17, 2022

lunaleaps commented Aug 17, 2022 •

edited

Loading

Simek commented Aug 17, 2022

lunaleaps commented Aug 17, 2022

Simek commented Aug 17, 2022

lunaleaps commented Aug 17, 2022 •

edited

Loading

Simek commented Aug 18, 2022 •

edited

Loading

lunaleaps commented Aug 18, 2022

kelset commented Aug 19, 2022

lunaleaps left a comment

Showcase page refresh #3235

Showcase page refresh #3235

Conversation

Simek commented Aug 1, 2022 • edited Loading

Why

How

Tests

Preview

netlify bot commented Aug 1, 2022

✅ Deploy Preview for react-native ready!

netlify bot commented Aug 1, 2022 • edited Loading

✅ Deploy Preview for react-native ready!

kelset left a comment

Choose a reason for hiding this comment

kelset Aug 8, 2022

Choose a reason for hiding this comment

lunaleaps Aug 17, 2022

Choose a reason for hiding this comment

kelset Aug 8, 2022

Choose a reason for hiding this comment

fortmarek Aug 16, 2022

Choose a reason for hiding this comment

lunaleaps Aug 16, 2022

Choose a reason for hiding this comment

kelset Aug 17, 2022 • edited Loading

Choose a reason for hiding this comment

lunaleaps Aug 17, 2022

Choose a reason for hiding this comment

Simek Aug 17, 2022

Choose a reason for hiding this comment

lunaleaps commented Aug 17, 2022 • edited Loading

Simek commented Aug 17, 2022

lunaleaps commented Aug 17, 2022

Simek commented Aug 17, 2022

Preview

lunaleaps commented Aug 17, 2022 • edited Loading

Simek commented Aug 18, 2022 • edited Loading

lunaleaps commented Aug 18, 2022

kelset commented Aug 19, 2022

lunaleaps left a comment

Choose a reason for hiding this comment

Simek commented Aug 1, 2022 •

edited

Loading

netlify bot commented Aug 1, 2022 •

edited

Loading

kelset Aug 17, 2022 •

edited

Loading

lunaleaps commented Aug 17, 2022 •

edited

Loading

lunaleaps commented Aug 17, 2022 •

edited

Loading

Simek commented Aug 18, 2022 •

edited

Loading