Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The New Architecture section editorial review #3288

Merged
merged 24 commits into from
Sep 8, 2022

Commits on Jul 6, 2022

  1. Configuration menu
    Copy the full SHA
    5a9622f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b106cd6 View commit details
    Browse the repository at this point in the history
  3. Guide to creating a New Architecture app from template (facebook#3056)

    * Start new template guide
    
    This is a first iteration. I want to get feedback on a few aspects, so
    starting from here as a baseline.
    
    * Update title
    
    * Use tabs for target OS
    
    Set up matching the style of "Getting Started", except I kept the
    headers inside the tabs for now as it makes for a useful right-hand TOC.
    
    * Capitalize New Architecture, simplify
    
    * Preliminary section for Hermes
    
    Add section for recommending enabling Hermes. Not sure of contents yet,
    and still have to test.
    
    * Reword to emphasize importance of Hermes usage
    
    * Show new arch in use
    
    * Add build speed article link
    
    * Add pro tip for pod install alias
    
    * Restructure, repeat less
    
    Favor linking to original setup guide instead of repeating content.
    
    * Note about Expo
    
    * Include command on uninstalling global CLI
    
    * How to learn more
    
    * Remove headers in tabs
    
    They don't work correctly with the righthand TOC.
    
    * Make header more clear
    
    * Use quote block less often
    
    There was way too much yellow.
    
    * Opt for instructions using XCode
    
    Because `xcodebuild clean` already failed me once when XCode GUI clean
    worked.
    
    * Fix lint issue
    
    * Improve wording
    
    * Use product name
    
    * Fix line wraps
    
    * Reword based on feedback
    
    * Note use of bundle install
    
    * Pod removal instructions
    
    Also standardize on using yarn scripts from template for commands, it's
    a little confusing to see the mix of `npx` and `yarn` once we start
    referring to `yarn pod-install`
    
    * Convert quotes to admonitions
    
    * Convert Note: to admonitions
    
    * Feedback: Change admonitions to caution
    
    * PR feedback
    lindboe authored and Riccardo Cipolleschi committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    38eb7f2 View commit details
    Browse the repository at this point in the history
  4. New Architecture landing page (facebook#3072)

    * First draft of landing page
    
    * Add migration and backwards compatibility links
    
    * lint fix
    
    * Restructure slightly, leaning more on context from Why a New Architecture
    
    * Don't need md in links
    
    * Suggested rewording
    
    * Rephrase pillar summaries
    lindboe authored and Riccardo Cipolleschi committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    5684e88 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a869a53 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    5597845 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    61cd230 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2022

  1. Configuration menu
    Copy the full SHA
    8a9b70f View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2022

  1. [FEAT][TNA] Fabric Component Guide (facebook#3132)

    * [Feat] Add intro for Fabric Components
    
    * feat: add guide to create a Fabric Component
    Riccardo committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    8ad2465 View commit details
    Browse the repository at this point in the history
  2. Add page on codegen (facebook#3155)

    Riccardo committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    449c3ea View commit details
    Browse the repository at this point in the history
  3. [FEAT] TurboModules guide (facebook#3168)

    * [Feat] Add intro for Fabric Components
    
    * feat: add guide to create a Fabric Component
    
    * Beginning of guide/folder structure
    
    * WIP JS Spec
    
    * specification section
    
    * Configuration
    
    * native code intro
    
    * Must be named Spec
    
    * Best stab at iOS native code, but I don't know how to describe what's going on in the code very well. Extrapolated what I could.
    
    * Android instructions
    
    iOS isn't working for me. Builds, but can't load module.
    
    Writing up Android auto-linking next because the steps I tested did
    work.
    
    * Include linking instructions from RNNArch repo
    
    * Add example JavaScript
    
    * native modules link
    
    * Address quick feedback items
    
    * Remove, fix for rebased branch
    
    * fix TM parameter on Android
    
    * Revert to 'Codegen' casing
    
    * Revert folly version change
    
    2021.07.22 is for current version on main
    
    * fix typo
    
    * getTurboModule explainer
    
    * Sentence edits
    
    - Fix acronym bolding
    - Change wording to "recommended" because "standard" has other
      connotations of possibly being required
    - Parentheses unnecessary, distracting
    
    * Remove TODO for now
    
    Getting inconsistent results here, not sure if this is wrong or not;
    removing TODO for now so it doesn't block anything
    
    * ABI rephrase, more in line with new Fabric guide wording
    
    * Explain shared C++ code more
    
    * feat: add guide to create a Fabric Component
    
    * feat: add guide to create a Fabric Component
    
    * package.json description
    
    * Lint fixes
    
    * fix: Move JS constants to reduce changes
    
    * fix: Remove newline
    
    * feat: add required step for Android Codegen
    
    * fix: use the proper links
    
    Co-authored-by: Riccardo Cipolleschi <cipolleschi@fb.com>
    lindboe and Riccardo Cipolleschi committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    444ec53 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2022

  1. wip: migration guide review (facebook#3200)

    Riccardo committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    18041b0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8dcff86 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2022

  1. Configuration menu
    Copy the full SHA
    28d7847 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2022

  1. Configuration menu
    Copy the full SHA
    c8b20bb View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2022

  1. Configuration menu
    Copy the full SHA
    9d079e9 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2022

  1. Configuration menu
    Copy the full SHA
    dac9956 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2022

  1. Configuration menu
    Copy the full SHA
    3a9f149 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2022

  1. Configuration menu
    Copy the full SHA
    082a2b1 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2022

  1. Configuration menu
    Copy the full SHA
    9abc29d View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2022

  1. Update docs/the-new-architecture/pillars-fabric-components.md

    correcting the article
    
    Co-authored-by: Riccardo <riccardo.cipolleschi@gmail.com>
    arati-1 and cipolleschi committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    5250e20 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6a59634 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2022

  1. Configuration menu
    Copy the full SHA
    86fd541 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2022

  1. Configuration menu
    Copy the full SHA
    93514b4 View commit details
    Browse the repository at this point in the history