-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The New Architecture section editorial review #3288
Commits on Jul 6, 2022
-
[Do Not Merge] Refactoring The New Architecture (facebook#3029)
Riccardo committedJul 6, 2022 Configuration menu - View commit details
-
Copy full SHA for 5a9622f - Browse repository at this point
Copy the full SHA 5a9622fView commit details -
[Guide - The New Architecture] What Backward Compatibility Is (facebo…
Riccardo committedJul 6, 2022 Configuration menu - View commit details
-
Copy full SHA for b106cd6 - Browse repository at this point
Copy the full SHA b106cd6View commit details -
Guide to creating a New Architecture app from template (facebook#3056)
* Start new template guide This is a first iteration. I want to get feedback on a few aspects, so starting from here as a baseline. * Update title * Use tabs for target OS Set up matching the style of "Getting Started", except I kept the headers inside the tabs for now as it makes for a useful right-hand TOC. * Capitalize New Architecture, simplify * Preliminary section for Hermes Add section for recommending enabling Hermes. Not sure of contents yet, and still have to test. * Reword to emphasize importance of Hermes usage * Show new arch in use * Add build speed article link * Add pro tip for pod install alias * Restructure, repeat less Favor linking to original setup guide instead of repeating content. * Note about Expo * Include command on uninstalling global CLI * How to learn more * Remove headers in tabs They don't work correctly with the righthand TOC. * Make header more clear * Use quote block less often There was way too much yellow. * Opt for instructions using XCode Because `xcodebuild clean` already failed me once when XCode GUI clean worked. * Fix lint issue * Improve wording * Use product name * Fix line wraps * Reword based on feedback * Note use of bundle install * Pod removal instructions Also standardize on using yarn scripts from template for commands, it's a little confusing to see the mix of `npx` and `yarn` once we start referring to `yarn pod-install` * Convert quotes to admonitions * Convert Note: to admonitions * Feedback: Change admonitions to caution * PR feedback
Configuration menu - View commit details
-
Copy full SHA for 38eb7f2 - Browse repository at this point
Copy the full SHA 38eb7f2View commit details -
New Architecture landing page (facebook#3072)
* First draft of landing page * Add migration and backwards compatibility links * lint fix * Restructure slightly, leaning more on context from Why a New Architecture * Don't need md in links * Suggested rewording * Rephrase pillar summaries
Configuration menu - View commit details
-
Copy full SHA for 5684e88 - Browse repository at this point
Copy the full SHA 5684e88View commit details -
[Guide - The New Architecture] Why A New Architecture (facebook#3043)
Riccardo committedJul 6, 2022 Configuration menu - View commit details
-
Copy full SHA for a869a53 - Browse repository at this point
Copy the full SHA a869a53View commit details -
[Guide - The New Architecture] Pillars (facebook#3046)
Riccardo committedJul 6, 2022 Configuration menu - View commit details
-
Copy full SHA for 5597845 - Browse repository at this point
Copy the full SHA 5597845View commit details -
[Guide - The New Architecture] TurboModules as Native Modules (facebo…
Riccardo committedJul 6, 2022 Configuration menu - View commit details
-
Copy full SHA for 61cd230 - Browse repository at this point
Copy the full SHA 61cd230View commit details
Commits on Jul 7, 2022
-
[Guide - The New Architecture] Fabric Components as Native Components (…
Riccardo committedJul 7, 2022 Configuration menu - View commit details
-
Copy full SHA for 8a9b70f - Browse repository at this point
Copy the full SHA 8a9b70fView commit details
Commits on Jul 20, 2022
-
[FEAT][TNA] Fabric Component Guide (facebook#3132)
* [Feat] Add intro for Fabric Components * feat: add guide to create a Fabric Component
Riccardo committedJul 20, 2022 Configuration menu - View commit details
-
Copy full SHA for 8ad2465 - Browse repository at this point
Copy the full SHA 8ad2465View commit details -
Add page on codegen (facebook#3155)
Riccardo committedJul 20, 2022 Configuration menu - View commit details
-
Copy full SHA for 449c3ea - Browse repository at this point
Copy the full SHA 449c3eaView commit details -
[FEAT] TurboModules guide (facebook#3168)
* [Feat] Add intro for Fabric Components * feat: add guide to create a Fabric Component * Beginning of guide/folder structure * WIP JS Spec * specification section * Configuration * native code intro * Must be named Spec * Best stab at iOS native code, but I don't know how to describe what's going on in the code very well. Extrapolated what I could. * Android instructions iOS isn't working for me. Builds, but can't load module. Writing up Android auto-linking next because the steps I tested did work. * Include linking instructions from RNNArch repo * Add example JavaScript * native modules link * Address quick feedback items * Remove, fix for rebased branch * fix TM parameter on Android * Revert to 'Codegen' casing * Revert folly version change 2021.07.22 is for current version on main * fix typo * getTurboModule explainer * Sentence edits - Fix acronym bolding - Change wording to "recommended" because "standard" has other connotations of possibly being required - Parentheses unnecessary, distracting * Remove TODO for now Getting inconsistent results here, not sure if this is wrong or not; removing TODO for now so it doesn't block anything * ABI rephrase, more in line with new Fabric guide wording * Explain shared C++ code more * feat: add guide to create a Fabric Component * feat: add guide to create a Fabric Component * package.json description * Lint fixes * fix: Move JS constants to reduce changes * fix: Remove newline * feat: add required step for Android Codegen * fix: use the proper links Co-authored-by: Riccardo Cipolleschi <cipolleschi@fb.com>
Configuration menu - View commit details
-
Copy full SHA for 444ec53 - Browse repository at this point
Copy the full SHA 444ec53View commit details
Commits on Aug 1, 2022
-
wip: migration guide review (facebook#3200)
Riccardo committedAug 1, 2022 Configuration menu - View commit details
-
Copy full SHA for 18041b0 - Browse repository at this point
Copy the full SHA 18041b0View commit details -
Merge branch 'main' into feat/new-architecture-guide-refactoring
Riccardo committedAug 1, 2022 Configuration menu - View commit details
-
Copy full SHA for 8dcff86 - Browse repository at this point
Copy the full SHA 8dcff86View commit details
Commits on Aug 8, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 28d7847 - Browse repository at this point
Copy the full SHA 28d7847View commit details
Commits on Aug 11, 2022
-
Configuration menu - View commit details
-
Copy full SHA for c8b20bb - Browse repository at this point
Copy the full SHA c8b20bbView commit details
Commits on Aug 17, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 9d079e9 - Browse repository at this point
Copy the full SHA 9d079e9View commit details
Commits on Aug 22, 2022
-
Configuration menu - View commit details
-
Copy full SHA for dac9956 - Browse repository at this point
Copy the full SHA dac9956View commit details
Commits on Aug 24, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 3a9f149 - Browse repository at this point
Copy the full SHA 3a9f149View commit details
Commits on Aug 25, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 082a2b1 - Browse repository at this point
Copy the full SHA 082a2b1View commit details
Commits on Aug 30, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 9abc29d - Browse repository at this point
Copy the full SHA 9abc29dView commit details
Commits on Sep 1, 2022
-
Update docs/the-new-architecture/pillars-fabric-components.md
correcting the article Co-authored-by: Riccardo <riccardo.cipolleschi@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5250e20 - Browse repository at this point
Copy the full SHA 5250e20View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a59634 - Browse repository at this point
Copy the full SHA 6a59634View commit details
Commits on Sep 7, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 86fd541 - Browse repository at this point
Copy the full SHA 86fd541View commit details
Commits on Sep 8, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 93514b4 - Browse repository at this point
Copy the full SHA 93514b4View commit details