Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove findNodeHandle and measure*() New Architecture Migration Steps #3488

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

yungsters
Copy link
Contributor

Updates the New Architecture migration guide in the following ways:

  • Removed the findNodeHandle and measure*() migration steps.
  • Rewrote the introduction for this section of the migration steps.
    • Added more details on our plans to eventually deprecate UIManager, but to continue supporting it (and the development is actively ongoing).
    • Omit references to the deprecation of findNodeHandle.
    • In lieu of removing the code snippets from the obsolete measure*() section, I've included a code snippet demonstrating usage of the native component instance methods.

Screenshot of the React Native New Architecture migration documentation

@netlify
Copy link

netlify bot commented Dec 22, 2022

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit c82ea81
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/63b46d85a0c3770009484861
😎 Deploy Preview https://deploy-preview-3488--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@yungsters
Copy link
Contributor Author

I think we should wait until 0.71 is released before merging this.

Also, I just remembered that the code snippet should be using viewRef.current.measure(…), not viewRef.measure(…).

Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks very good to me and it is refreshing to see so much "code" removed! :D

I think we should wait until 0.71 is released before merging this.

It is already like this. When we merge this into main, the documentation is published as next version. When RN 0.71 is released, the next is automatically promoted to 0.71 and the new next will refer to 0.72. 😉

@yungsters
Copy link
Contributor Author

I just spotted a typo, "to continuing". Will fix (and subsequently merge) when I'm back from my vacation! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants