feat: mention local modules #3877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
szymonrybczak
force-pushed
the
feat/mention-local-module
branch
from
1062c27 to
af6b331
Compare
szymonrybczak
force-pushed
the
feat/mention-local-module
branch
from
af6b331 to
91a4386
Compare
cipolleschi
reviewed
Nov 2, 2023
Comment on lines
+60
to
+62
| ```shell | ||
| npm install | ||
| ``` |
There was a problem hiding this comment.
Should we make a call and only use yarn, @cortinico?
I remember having discussions that npm is brittle, but I'm, not totally sure.
There was a problem hiding this comment.
In theory this should be tabbed npm/yarn as we do for all the other pages (like here https://reactnative.dev/docs/react-devtools)
Co-authored-by: Riccardo Cipolleschi <riccardo.cipolleschi@gmail.com>
Co-authored-by: Riccardo Cipolleschi <riccardo.cipolleschi@gmail.com>
satya164
reviewed
Nov 2, 2023
Co-authored-by: Satyajit Sahoo <satyajit.happy@gmail.com>
szymonrybczak
commented
Dec 18, 2023
|
Can we get this merged? :) cc: @cortinico @cipolleschi |
satya164
reviewed
Feb 9, 2024
Co-authored-by: Satyajit Sahoo <satyajit.happy@gmail.com>
|
@szymonrybczak let's fix the CI and then we can merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! 👋
I'm adding informations about local modules directive with which user can create native component, native module etc. with one command.
Read more here: react-native-community/discussions-and-proposals#702 (comment)