Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Min OS Version columns to RN releases #4169

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

realsoelynn
Copy link
Contributor

Add Min OS Version columns for iOS and Android to RN versions pages

Screenshots

Screenshot 2024-08-02 at 3 28 43 PM

Copy link

netlify bot commented Aug 2, 2024

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit e8027a9
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/66ad5e3aef8ab600090f9125
😎 Deploy Preview https://deploy-preview-4169--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alanleedev
Copy link
Contributor

alanleedev commented Aug 2, 2024

Nice work!
Where do we link to this page from? https://reactnative.dev/versions
I had to google to find it.

It seems like it would be useful to have a link here: https://github.com/facebook/react-native/blob/main/README.md#-requirements

Copy link
Contributor

@alanleedev alanleedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding useful information.

@cortinico
Copy link
Contributor

Where do we link to this page from? reactnative.dev/versions

I think this page is not the best one to put this information (as @alanleedev said, this page is not in a menu and is a bit hard to find). I'd rather create a "compatibility page" somewhere else where add minSDK version and other infos (e.g. versions of Node, CocoaPods, Gradle, Java, Ruby)

@realsoelynn
Copy link
Contributor Author

Where do we link to this page from? reactnative.dev/versions

I think this page is not the best one to put this information (as @alanleedev said, this page is not in a menu and is a bit hard to find). I'd rather create a "compatibility page" somewhere else where add minSDK version and other infos (e.g. versions of Node, CocoaPods, Gradle, Java, Ruby)

Sure @cortinico . I loved that idea. I will update my PR soon to create a Compatibility Page.

@cortinico
Copy link
Contributor

I will update my PR soon to create a Compatibility Page.

For inspiration: I was thinking about something like this one https://detekt.dev/docs/introduction/compatibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants