Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: measureLayout() with native node handler is obsolete when using new architecture #4277

Merged
merged 4 commits into from
Nov 23, 2024

Conversation

LunatiqueCoder
Copy link
Contributor

@LunatiqueCoder LunatiqueCoder commented Oct 12, 2024

 (NOBRIDGE) LOG  Bridgeless mode is enabled
 (NOBRIDGE) ERROR  Warning: ref.measureLayout must be called with a ref to a native component.

measureLayout() with relativeToNativeNode handler (instead of reference) seems to be OBSOLETE when using the new architecture.

Copy link

netlify bot commented Oct 12, 2024

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit ad44ac2
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/67421c16397e5e0008caf294
😎 Deploy Preview https://deploy-preview-4277--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@LunatiqueCoder LunatiqueCoder changed the title docs/measureLayout-obsolete-with-native-node-handler docs: measureLayout() is obsolete with native node handler when using new architecture Oct 12, 2024
@LunatiqueCoder LunatiqueCoder changed the title docs: measureLayout() is obsolete with native node handler when using new architecture docs: measureLayout() with native node handler is obsolete when using new architecture Oct 12, 2024
@javache
Copy link
Member

javache commented Nov 20, 2024

Can you update this in the latest docs instead of the 0.75 version?

@LunatiqueCoder
Copy link
Contributor Author

Added for 0.76. Let me know if I should remove the version-0.75 change as well.

@Abbondanzo
Copy link
Contributor

Keeping the version-0.75 is great. Could you make the same changes to versioned docs for 0.76 too?

@LunatiqueCoder
Copy link
Contributor Author

@Abbondanzo Hmm, so weird. Pressing the "Edit this page"on the docs seems to be leading me to the wrong place on 0.76.

Updated, hope everything's ok now.

@Abbondanzo
Copy link
Contributor

@Abbondanzo Hmm, so weird. Pressing the "Edit this page"on the docs seems to be leading me to the wrong place on 0.76.

Updated, hope everything's ok now.

Good callout, the "Edit this page" button will only point to the latest version of the docs and not the version you're looking at, but we can update that. Thanks for making these last changes so quickly!

@Abbondanzo Abbondanzo merged commit 6af7f71 into facebook:main Nov 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants