Skip to content

Commit

Permalink
Fix default shadow radius in TextAttributeProps (#36621)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #36621

After D44302691 enabled textShadow, there was a subtle 1px shadow on any new text which I did't spot, but screenshot tests did (after commit which is non-ideal, but there is more work to make these land blocking).

This is because unlike `ReactBaseTextShadowNode` in paper which defaults to a radius of zero (no shadow), `TextAttributes` in Fabric defaults to a radius of 1px. Just previously never displayed.

Without shadow:
https://pxl.cl/2z2wX

With shadow:
https://pxl.cl/2z2x0

This changes the default to zero, which will cause us to skip adding the span, and matches previous behavior in Paper.

I double-checked the other props are defaulted the same way between `BaseTextShadowNode` (Paper) and `TextAttributes` (Fabric).

Changelog:
[Android][Fixed] - Fix default shadow radius in TextAttributeProps

Reviewed By: javache

Differential Revision: D44364446

fbshipit-source-id: d207367608291048001403d292f881c0842113f9
  • Loading branch information
NickGerleman authored and facebook-github-bot committed Mar 24, 2023
1 parent 776fe7a commit 05fd10d
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ public class TextAttributeProps {

protected float mTextShadowOffsetDx = 0;
protected float mTextShadowOffsetDy = 0;
protected float mTextShadowRadius = 1;
protected float mTextShadowRadius = 0;
protected int mTextShadowColor = DEFAULT_TEXT_SHADOW_COLOR;

protected boolean mIsUnderlineTextDecorationSet = false;
Expand Down

0 comments on commit 05fd10d

Please sign in to comment.