Skip to content

Commit

Permalink
fix(cli + tests): Bump metro to 0.66 + fix test manual script (#31597)
Browse files Browse the repository at this point in the history
Summary:
Bumped react-native-community/cli to v6 to update metro to 0.66 to fix fast-refresh issues
Also updated the manual test e2e script for easier testing. (using npm install would create a package-lock.json and conflict with yarn.lock)

## Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://github.com/facebook/react-native/wiki/Changelog
-->

[GENERAL] [UPDATE] - updated react-native-community/cli to v6 (hence updating metro to 0.66)

Pull Request resolved: #31597

Test Plan: I've tested fast-refresh works with / without hermes

Reviewed By: TheSavior

Differential Revision: D28852660

Pulled By: yungsters

fbshipit-source-id: af338e4dd1d52c62949d71f42773963d89bca9db
  • Loading branch information
Titozzz authored and facebook-github-bot committed Jun 3, 2021
1 parent 281daf1 commit 0d32aef
Show file tree
Hide file tree
Showing 3 changed files with 128 additions and 272 deletions.
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,9 @@
},
"dependencies": {
"@jest/create-cache-key-function": "^27.0.1",
"@react-native-community/cli": "^5.0.1-alpha.0",
"@react-native-community/cli-platform-android": "^5.0.1-alpha.0",
"@react-native-community/cli-platform-ios": "^5.0.1-alpha.0",
"@react-native-community/cli": "^6.0.0-rc.0",
"@react-native-community/cli-platform-android": "^6.0.0-rc.0",
"@react-native-community/cli-platform-ios": "^6.0.0-rc.0",
"@react-native/assets": "1.0.0",
"@react-native/normalize-color": "1.0.0",
"@react-native/polyfills": "1.0.0",
Expand Down
2 changes: 1 addition & 1 deletion scripts/test-manual-e2e.sh
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ rm -rf android

success "Generated artifacts for Maven"

npm install
yarn

success "Killing any running packagers"
lsof -i :8081 | grep LISTEN
Expand Down
Loading

0 comments on commit 0d32aef

Please sign in to comment.