Skip to content

Commit

Permalink
Add missing hermes include (#25872)
Browse files Browse the repository at this point in the history
Summary:
The Hermes react executor c++ code is not currently getting built. The include was probably forgotten when merging hermes on master. The 0.60 branch does have it https://github.com/facebook/react-native/blob/0.60-stable/ReactAndroid/src/main/jni/react/jni/Android.mk#L72

## Changelog

[Android] [Fixed] - Add missing hermes include
Pull Request resolved: #25872

Test Plan: Run an app with hermes enabled on RN master

Differential Revision: D16559354

Pulled By: cpojer

fbshipit-source-id: 95cfbf65481c2f0d0e5c53ca35f327753e7b99ae
  • Loading branch information
janicduplessis authored and facebook-github-bot committed Jul 30, 2019
1 parent bf5e73e commit 1db96a3
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions ReactAndroid/src/main/jni/react/jni/Android.mk
Original file line number Diff line number Diff line change
Expand Up @@ -77,3 +77,4 @@ include $(REACT_SRC_DIR)/turbomodule/core/jni/Android.mk
# $(call import-module,jscexecutor)

include $(REACT_SRC_DIR)/jscexecutor/Android.mk
include $(REACT_SRC_DIR)/../hermes/reactexecutor/Android.mk

0 comments on commit 1db96a3

Please sign in to comment.