Skip to content

Commit

Permalink
[RCTBridge] Have RCTBridge.loading return RCTBatchedBridge.loading
Browse files Browse the repository at this point in the history
Summary:
The parent RCTBridge no longer tracks the JS loading since that has been handed off to the RCTBatchedBridge. To make the `loading` property accurate again, just expose the batch bridge's loading property from the parent bridge (note: I didn't make it KVO-compliant).

Fixes #1199
Closes #1200
Github Author: James Ide <ide@jameside.com>

Test Plan: Imported from GitHub, without a `Test Plan:` line.
  • Loading branch information
ide committed May 15, 2015
1 parent e467fb7 commit 2497c02
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions React/Base/RCTBridge.m
Original file line number Diff line number Diff line change
Expand Up @@ -836,6 +836,11 @@ - (void)setUp
_batchedBridge = [[RCTBatchedBridge alloc] initWithParentBridge:self];
}

- (BOOL)isLoading
{
return _batchedBridge.loading;
}

- (BOOL)isValid
{
return _batchedBridge.isValid;
Expand Down

0 comments on commit 2497c02

Please sign in to comment.