Skip to content

Commit

Permalink
Update React.podspec for RCTText
Browse files Browse the repository at this point in the history
Summary:
Some of the classes of RCTText are now in the subfolders, this will fix pod integration for texts

<!--
Thank you for sending the PR! We appreciate you spending the time to work on these changes.

Help us understand your motivation by explaining why you decided to make this change.

You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html

Happy contributing!

-->

I have integrated React Native into my project with [this guide](https://facebook.github.io/react-native/docs/integration-with-existing-apps.html) and got the error `No component found for view with name RCTText`. Searching in the web did not give any useful information so I started to dig into the code and found out that there is now subfolders and pod taking only root classes. After making this change project started to compile again.

Create empty project with pods integrated add `RCTText` subspec and in `.js` file add  some `<Text>` element

Fixed `RCTText` subspec integration.
Closes #17655

Differential Revision: D6751039

Pulled By: hramos

fbshipit-source-id: f4538d1125af2b45f36e2fa535382e032dbc8f4e
  • Loading branch information
hovox authored and ide committed Feb 6, 2018
1 parent f7bd2a3 commit 2c63f49
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion React.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ Pod::Spec.new do |s|

s.subspec "RCTText" do |ss|
ss.dependency "React/Core"
ss.source_files = "Libraries/Text/*.{h,m}"
ss.source_files = "Libraries/Text/**/*.{h,m}"
end

s.subspec "RCTVibration" do |ss|
Expand Down

2 comments on commit 2c63f49

@peppermints
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job!!!

@deno028
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great fix man

Please sign in to comment.