Skip to content

Commit

Permalink
Fix RawPropsParser for Windows (#33432)
Browse files Browse the repository at this point in the history
Summary:
Changes in 7cece34...189c2c8 broke build for Windows because of a conversion from size_t to int. Adds a static cast to int to fix the error and restore windows build

Error Message
```
##[error]node_modules\react-native\ReactCommon\react\renderer\core\RawPropsParser.cpp(100,42): Error C2220: the following warning is treated as an error
     3>D:\a\_work\1\s\node_modules\react-native\ReactCommon\react\renderer\core\RawPropsParser.cpp(100,42): error C2220: the following warning is treated as an error [D:\a\_work\1\s\vnext\Microsoft.ReactNative\Microsoft.ReactNative.vcxproj]
##[warning]node_modules\react-native\ReactCommon\react\renderer\core\RawPropsParser.cpp(100,42): **Warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data**
     3>D:\a\_work\1\s\node_modules\react-native\ReactCommon\react\renderer\core\RawPropsParser.cpp(100,42): warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data [D:\a\_work\1\s\vnext\Microsoft.ReactNative\Microsoft.ReactNative.vcxproj]
```

## Changelog

[General] [Fixed] - Restore Windows build with RawPropsParser.cpp

Pull Request resolved: #33432

Test Plan: Tested locally and changes pass in the react-native-windows pipeline, change is being merged into the main branch of react-native-windows.

Reviewed By: philIip

Differential Revision: D34907928

Pulled By: javache

fbshipit-source-id: 8b76cbef0b637f2d607a8aefd2998322c3245713
  • Loading branch information
TatianaKapos authored and facebook-github-bot committed Mar 17, 2022
1 parent b2517c3 commit 2d64d1d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ReactCommon/react/renderer/core/RawPropsParser.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ void RawPropsParser::preparse(RawProps const &rawProps) const noexcept {
rawProps.keyIndexToValueIndex_.resize(keyCount, kRawPropsValueIndexEmpty);

// Resetting the cursor, the next increment will give `0`.
rawProps.keyIndexCursor_ = keyCount - 1;
rawProps.keyIndexCursor_ = static_cast<int>(keyCount - 1);

switch (rawProps.mode_) {
case RawProps::Mode::Empty:
Expand Down

0 comments on commit 2d64d1d

Please sign in to comment.