Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Reduce visibility of CoreModulesPackage (#41087)
Summary: Pull Request resolved: #41087 CoreModulesPackage is not being used outside of its package (neither in OSS or at Meta), I'm reducing its visibiity to package. If you are using this class, please contact us and we will consider increasing visibiity again. bypass-github-export-checks changelog: [Android][Breaking] Reduce visibility of CoreModulesPackage class Reviewed By: christophpurrer Differential Revision: D50338546 fbshipit-source-id: 3f0ce4dd22ddfa6743760ad378e7c6e45ab58127
- Loading branch information
30b9b01
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mdvacca Hi, we are currently using it. Our app is creating a new react context to run some syncronization operations in a different thread during the lifecycle of the app. In the meanwhile I created a custom implementation duplicating
CoreModulesPackage
and make it public (considering that all internal dependencies and types are public) but I wanna avoid future issues 🙏 LMK if you need more info